xfer: guard against path buffer overflow in file command#31
Open
Swissola wants to merge 3 commits into
Open
Conversation
sleep=Donald Duck, idle=Bongo Cat, busy=SpongeBob multitasking, attention=Surprised Pikachu (Nouns glasses), celebrate=Peanuts party, dizzy=Powerpuff Girls spiral eyes, heart=heart eyes ghost. Source GIFs in characters/memes-src/, device-ready pack in characters/memes/. Built with prep_character.py at 96x98px, 64 colours per frame. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Track the current peer BD address in onConnect (extended overload). bleRemoveCurrentBond() removes only that peer's LTK from NVS. The "unpair" JSON command now calls this instead of bleClearBonds(), so each host unpairs itself independently. bleClearBonds() is reserved for factory reset only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The file path was constructed with snprintf into an 80-byte buffer without checking whether the combined /characters/<name>/<path> string exceeded it. A long path from the bridge would silently truncate, opening a mangled filename. Check the snprintf return value and reject with a false ack if the result would overflow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snprintfwhen building the install path in thefilecommand handlerfalseack if the combined path would overflow the 80-byte bufferMotivation
/characters/<name>/<path>was written intochar full[80]without validating the length ofpathfrom the bridge.snprintfsilently truncates on overflow, so a long path would open a mangled filename with no error signalled back to the sender. In the worst case this creates a file at an unintended location on LittleFS.The buffer is 80 bytes;
/characters/is 13,_xCharNameup to 23,/is 1, leaving 42 bytes for the path component. Any bridge-supplied path longer than that now gets a{"ack":"file","ok":false}response rather than silent truncation.Behaviour after this change
fileack returnsok: false, transfer is rejected cleanlyTest plan
filecommand with a path > 42 characters — device repliesok: false🤖 Generated with Claude Code