refactor: drive bool settings from a descriptor table#36
Closed
Swissola wants to merge 3 commits into
Closed
Conversation
sleep=Donald Duck, idle=Bongo Cat, busy=SpongeBob multitasking, attention=Surprised Pikachu (Nouns glasses), celebrate=Peanuts party, dizzy=Powerpuff Girls spiral eyes, heart=heart eyes ghost. Source GIFs in characters/memes-src/, device-ready pack in characters/memes/. Built with prep_character.py at 96x98px, 64 colours per frame. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Track the current peer BD address in onConnect (extended overload). bleRemoveCurrentBond() removes only that peer's LTK from NVS. The "unpair" JSON command now calls this instead of bleClearBonds(), so each host unpairs itself independently. bleClearBonds() is reserved for factory reset only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the parallel lists in settingsLoad(), settingsSave(), settingsItems[], applySetting(), and drawSettings() with a single BOOL_SETTINGS[] table in stats.h. Adding a new bool setting now requires one entry in the table; everything else derives from it automatically. Non-bool settings (clockRot) and special actions (brightness, pet, reset, back) stay explicit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Closing as this is outside the scope of the upstream reference implementation per CONTRIBUTING.md. This change is maintained in the community fork at https://github.com/Swissola/claude-desktop-buddy — see the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace six parallel hardcoded lists with a single
BOOL_SETTINGS[]descriptor table instats.h. Adding a new bool setting now requires one entry in the table;settingsLoad(),settingsSave(),drawSettings(), andapplySetting()all derive from it automatically.Motivation
Every bool setting previously had to be registered in six separate places:
Settingsstruct fieldsettingsLoad()NVS readsettingsSave()NVS writesettingsItems[]menu labelapplySetting()switch casedrawSettings()vals[]display arrayMiss any one of them and the setting silently misbehaves with no compiler warning. This is a maintenance hazard that compounds as more settings are added.
What changed
BoolSettingDefstruct added tostats.h— label, NVS key, pointer-to-member, defaultBOOL_SETTINGS[]table replaces the scattered definitions forsound,bt,wifi,led,hudSETTINGS_Nis now derived:1 + BOOL_SETTINGS_N + 4— stays correct as the table growsclockRot) and special actions (brightness, pet, reset, back) remain explicitTest plan
🤖 Generated with Claude Code