Generic

[rudiultra]

What I like on your driver:

• small
• low memory
• text scaling is great (no fonts necessary)

So I did some updates to have some functions more:

• generic driver for more TFT like ili93xx
  I added just a specific init routine. The spi commands are most the same.
  So just the init was the problem.

But the fill rectangle function was not proper working.
I changed the following:
#self.set_window(x,y,x+w-1,y+1-w)
self.set_window(x,y,x+w-1,y+w-1)

My version works on st7789 and the ili93xx. Your version is st7789 specific.
I did not a closer research why.

If you are interested on my changes then please let me know.

[marc-ramsey]

Quick comment, the above fix works with square displays only, the correct fix for st7789_base.py:227 is:

self.set_window(x,y,x+w-1,y+h-1)

I'll fork and submit a pull request for this and a few other bugs I found, shortly, but otherwise the code works quite well for my purposes. Something else that needs a bit of documentation, in order to avoid garbage pixels at two edges of an ST7789 160x128 display in landscape mode, I had to set xstart=2 and ystart=1. Thanks, Salvatore!

[antirez]

@ByCzech fixed the issue with the set_window(). Any other change needed? Now it should work. @rudiultra mentioned issues in the initialization, probably some timing issue? Please could you elaborate? Thank you.

[marc-ramsey]

Thanks! I was waiting to see if there was a response before submitting a pull request. The other "fix" I have reworks some of the functions in ST7789_base.py (char, text, fast_mono_to_rgb, showmono) into more framebuf compliant text and blit implementations with clipping. Do you have any interest in this code?

[rudiultra]

Sure. I used your st77xx as base for all tft's with a SPI interface.
I just added a section to do a specific initialization for every display type.
After that the setwindow and raw input works in the same way for all others.
The init sequence I copyied from a other project:
https://github.com/PyDevices/pydisplay
The path for the init sequences is there: pydisplay/drivers/display/

So I combined the idea from both projects with the result to have a low memory driver.