Skip to content

fix: avoid scanner file read race #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aolingge wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: avoid scanner file read race #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
541abf3
fix: avoid scanner file read race
aolingge May 7, 2026
38a5784
Merge branch 'main' into fix/codeql-file-race
aolingge May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/scanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { readdir, readFile, stat } from "node:fs/promises";
import { open, readdir } from "node:fs/promises";
import { join, relative } from "node:path";
import { scanFileWithRules } from "./rules.js";
import type { Finding, ScanFile, ScanResult, ScanTargetInput } from "./types.js";
Expand Down Expand Up @@ -84,13 +84,16 @@ async function walk(root: string, current: string, files: ScanFile[], excludePat
continue;
}

const fileStat = await stat(absolutePath);
if (fileStat.size > MAX_FILE_BYTES) {
continue;
const file = await open(absolutePath, "r");
try {
const fileStat = await file.stat();
if (fileStat.size <= MAX_FILE_BYTES) {
const content = await file.readFile("utf8");
files.push({ path: relativePath, content });
}
} finally {
await file.close();
}

const content = await readFile(absolutePath, "utf8");
files.push({ path: relativePath, content });
}
}

Expand Down