NO-JIRA Try to fix tests

Author: Havret

.editorconfig

@@ -0,0 +1,12 @@
+# editorconfig.org
+# top-most EditorConfig file
+root = true
+
+# Visual Studio XML project files
+[*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,projitems,shproj}]
+indent_size = 2
+charset = utf-8
+
+# Visual Studio and .NET related XML config files
+[*.{props,targets,ruleset,config,nuspec,resx,vsixmanifest,vsct,stylecop}]
+indent_size = 2

.github/workflows/build.yml

@@ -17,7 +17,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: '9.0.x'
+        dotnet-version: '8.0.x'
 
     - name: Start ActiveMQ with Docker Compose
       run: docker compose up -d activemq
@@ -32,7 +32,7 @@ jobs:
       run: dotnet test test/nms-openwire-test.csproj --configuration Release --no-build --verbosity normal --logger trx --results-directory TestResults --filter "TestCategory!=Manual"
       env:
         NMSTestBroker: localhost
-        
+        activemqhost: localhost
     - name: Upload test results
       uses: actions/upload-artifact@v4
       if: always()

Directory.Build.props

@@ -0,0 +1,6 @@
+<Project>
+  <PropertyGroup>
+    <LangVersion>12</LangVersion>
+    <TargetFramework>net8.0</TargetFramework>
+  </PropertyGroup>
+</Project>

docker-compose.yml

@@ -11,5 +11,5 @@ services:
       retries: 5
       start_period: 60s
     environment:
-      - ACTIVEMQ_ADMIN_LOGIN=admin
-      - ACTIVEMQ_ADMIN_PASSWORD=admin
+      - ACTIVEMQ_CONNECTION_USER=guest
+      - ACTIVEMQ_CONNECTION_PASSWORD=guest

nms-openwire.sln

@@ -7,6 +7,18 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "nms-openwire", "src\nms-ope
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "nms-openwire-test", "test\nms-openwire-test.csproj", "{D4034BFD-21F1-4836-B0A0-1C4161AB0110}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{A3B1E8EF-F189-4DF4-8531-4C37128AA3C3}"
+	ProjectSection(SolutionItems) = preProject
+	    Directory.Build.props = Directory.Build.props
+		LICENSE.txt = LICENSE.txt
+		RELEASE.md = RELEASE.md
+		README.md = README.md
+		NOTICE.txt = NOTICE.txt
+		docker-compose.yml = docker-compose.yml
+		.github\workflows\build.yml = .github\workflows\build.yml
+		.editorconfig = .editorconfig
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU

src/nms-openwire.csproj

@@ -21,7 +21,6 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <Authors>Apache ActiveMQ</Authors>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <LangVersion>8</LangVersion>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">

test/AMQNET366Test.cs

@@ -46,9 +46,9 @@ public override void SetUp()
         [Test, Timeout(30_000)]
         public void TestConnection()
         {
-            IConnectionFactory factory = new NMSConnectionFactory(NMSTestSupport.ReplaceEnvVar(connectionUri));
+            IConnectionFactory factory = new NMSConnectionFactory(ReplaceEnvVar(connectionUri));
 
-            using (connection = factory.CreateConnection())
+            using (connection = factory.CreateConnection("guest", "guest"))
             using (ISession session = connection.CreateSession())
             {
                 IDestination destination = SessionUtil.GetDestination(session, "queue://TEST.test.in");

test/AMQNET375Test.cs

@@ -53,7 +53,7 @@ public void TestZeroPrefetchConsumerGetsAllMessages()
 		private void Receive(int numberOfMessages)
 		{
             IConnectionFactory connectionFactory = new NMSConnectionFactory(NMSTestSupport.ReplaceEnvVar(BrokerUri));
-			using (IConnection connection = connectionFactory.CreateConnection())
+			using (IConnection connection = connectionFactory.CreateConnection("guest", "guest"))
 			{
 				connection.Start();
 
@@ -83,8 +83,8 @@ private void Receive(int numberOfMessages)
 
 		private void Send(int numberOfMessages)
 		{
-            IConnectionFactory connectionFactory = new NMSConnectionFactory(NMSTestSupport.ReplaceEnvVar(BrokerUri));
-			using (IConnection connection = connectionFactory.CreateConnection())
+            IConnectionFactory connectionFactory = new NMSConnectionFactory(ReplaceEnvVar(BrokerUri));
+			using (IConnection connection = connectionFactory.CreateConnection("guest", "guest"))
 			{
 				connection.Start();
 

test/Async/ConnectionFactoryTestAsync.cs

@@ -47,7 +47,7 @@ public async Task TestURI(string connectionURI)
 				Uri uri = URISupport.CreateCompatibleUri(NMSTestSupport.ReplaceEnvVar(connectionURI));
 				ConnectionFactory factory = new ConnectionFactory(uri);
 				Assert.IsNotNull(factory);
-				using(IConnection connection = await factory.CreateConnectionAsync("", ""))
+				using(IConnection connection = await factory.CreateConnectionAsync("guest", "guest"))
 				{
 					Assert.IsNotNull(connection);
 
@@ -74,7 +74,7 @@ public async Task TestURI(string connectionURI)
 			{
 				ConnectionFactory factory = new ConnectionFactory(NMSTestSupport.ReplaceEnvVar(connectionURI));
 				Assert.IsNotNull(factory);
-				using(IConnection connection = await factory.CreateConnectionAsync("", ""))
+				using(IConnection connection = await factory.CreateConnectionAsync("guest", "guest"))
 				{
 					Assert.IsNotNull(connection);
 
@@ -131,7 +131,7 @@ public async Task TestConnectionFactorySetParams(
 			factory.SendAcksAsync = sendAcksAsync;
 			factory.DispatchAsync = dispatchAsync;
 
-			using(Connection connection = await factory.CreateConnectionAsync() as Connection)
+			using(Connection connection = await factory.CreateConnectionAsync("guest", "guest") as Connection)
 			{
 				Assert.AreEqual(ackMode, connection.AcknowledgementMode);
 				Assert.AreEqual(asyncSend, connection.AsyncSend);
@@ -178,7 +178,7 @@ public async Task TestConnectionFactoryParseParams(
 
 			ConnectionFactory factory = new ConnectionFactory(NMSTestSupport.ReplaceEnvVar(connectionURI));
 
-			using(Connection connection = await factory.CreateConnectionAsync() as Connection)
+			using(Connection connection = await factory.CreateConnectionAsync("guest", "guest") as Connection)
 			{
 				Assert.AreEqual(ackMode, connection.AcknowledgementMode);
 				Assert.AreEqual(asyncSend, connection.AsyncSend);

test/Async/MessageProducerTestAsync.cs

@@ -35,7 +35,7 @@ public async Task TestProducerSendWithExpiry()
                 IConnectionFactory factory = new ConnectionFactory(NMSTestSupport.ReplaceEnvVar(uri));
 
     			// ConnectionFactory factory = new ConnectionFactory(uri);
-    			using(IConnection connection = await factory.CreateConnectionAsync())
+    			using(IConnection connection = await factory.CreateConnectionAsync("guest", "guest"))
     			using(ISession session = await connection.CreateSessionAsync())
     			{
     				IDestination destination = await session.GetTopicAsync("Test");