From 5d72077b8f70a9386f080699e6c5e441f1775730 Mon Sep 17 00:00:00 2001 From: Jarek Potiuk Date: Wed, 18 Nov 2026 16:08:01 +1100 Subject: [PATCH] fix(asf): give the main ruleset the review fields it needs asfyaml builds one pull-request rule from required_conversation_resolution and required_pull_request_reviews, and GitHub refuses that rule, and with it the whole ruleset, when the review fields are missing. The `main` ruleset was therefore never created after #2184 removed the classic protection. Add required_pull_request_reviews with zero required approvals, which keeps the approval requirement lifted; restoring it is now a change of the count to 1. Generated-by: Claude Opus 5 --- .asf.yaml | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/.asf.yaml b/.asf.yaml index de0173e0d..7d1e8770f 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -152,18 +152,24 @@ github: # No signed-commit requirement: contributors without GPG/SSH # signing could not contribute. # + # + # `required_pull_request_reviews` must be present whenever + # `required_conversation_resolution` is set: asfyaml builds one + # pull-request rule from both, and GitHub refuses that rule (and so + # the whole ruleset) without the review fields. + # # APPROVAL REQUIREMENT TEMPORARILY LIFTED. After becoming a # Top-Level Project every PR into `main` needed one committer # approval (#818). It is lifted while the marketplace installation # and the reworked permission handling land as many small, fast # iterations; this is a time-boxed exception, not a governance - # change. Restore by removing the leading `# ` from the three lines - # below. `dismiss_stale_reviews: false` keeps an approval across a + # change. Restore by setting `required_approving_review_count` to + # 1. `dismiss_stale_reviews: false` keeps an approval across a # rebase or a fixup push; `require_code_owner_reviews` stays off # because there is no CODEOWNERS file. - # required_pull_request_reviews: - # required_approving_review_count: 1 - # dismiss_stale_reviews: false + required_pull_request_reviews: + required_approving_review_count: 0 + dismiss_stale_reviews: false notifications: # Magpie is a Top-Level Project with its own mailing lists. All