Skip to content

Commit 08bf714

Browse files
committed
fix(release): carry the incubator disclaimer in CLI ZIPs
Generated-by: Codex
1 parent e148bb2 commit 08bf714

4 files changed

Lines changed: 6 additions & 2 deletions

File tree

.github/RELEASE_CHECKLIST.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ must never be exposed to fork or ordinary pull-request jobs.
4141
- `Maka-<version>-cli-mac-arm64.zip` and checksum;
4242
- `Maka-<version>-bundled-git-source.tar.gz` and checksum;
4343
- the platform update metadata and Desktop ZIPs produced by electron-builder.
44-
6. Inspect the CLI ZIP. It must contain `bin/maka`, `RELEASE.json`, `LICENSE`, `NOTICE`,
44+
6. Inspect the CLI ZIP. It must contain `bin/maka`, `RELEASE.json`, `DISCLAIMER-WIP`, `LICENSE`, `NOTICE`,
4545
`THIRD_PARTY_NOTICES.txt`, the pinned Node license, and no `bin/maka-agent`.
4646
7. Confirm `RELEASE.json` records the Draft's product version and source SHA, the official Node
4747
URL/archive/digest, npm version, workspace and production dependency closures, dependency

docs/cli-distribution.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ The TUI is the default interactive mode of `maka`, not a separate artifact.
3939
| `signing` | `developer-id-notarized` for release artifacts; `development` for local checks |
4040

4141
The CLI-specific `THIRD_PARTY_NOTICES.txt` must enumerate exactly the external production
42-
dependencies recorded in `RELEASE.json`. The archive checksum is generated only after signing and
42+
dependencies recorded in `RELEASE.json`. The archive also carries the repository's
43+
`DISCLAIMER-WIP`, `LICENSE`, and `NOTICE`. The archive checksum is generated only after signing and
4344
notarization complete.
4445

4546
Every Mach-O file inside the archive is signed and the ZIP is submitted to Apple's notary service.

scripts/package-macos-arm64-cli.mjs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -735,6 +735,7 @@ export async function packageMacosArm64Cli({
735735

736736
const version = identity.version;
737737
await Promise.all([
738+
access(join(repoRoot, 'DISCLAIMER-WIP')),
738739
access(join(repoRoot, 'LICENSE')),
739740
access(join(repoRoot, 'NOTICE')),
740741
...workspacePackages.map(({ directory }) => access(join(directory, 'dist'))),
@@ -788,6 +789,7 @@ export async function packageMacosArm64Cli({
788789
await Promise.all([
789790
copyFile(officialNode.execPath, join(embeddedNodeDirectory, 'bin', 'node')),
790791
copyFile(officialNode.licensePath, join(embeddedNodeDirectory, 'LICENSE')),
792+
copyFile(join(repoRoot, 'DISCLAIMER-WIP'), join(archiveRoot, 'DISCLAIMER-WIP')),
791793
copyFile(join(repoRoot, 'LICENSE'), join(archiveRoot, 'LICENSE')),
792794
copyFile(join(repoRoot, 'NOTICE'), join(archiveRoot, 'NOTICE')),
793795
writeFile(join(binDirectory, 'maka'), macosArm64CliWrapper(), 'utf8'),

scripts/verify-macos-arm64-cli.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -532,6 +532,7 @@ export async function verifyMacosArm64Cli(
532532
makaPath,
533533
metadataPath,
534534
thirdPartyNoticesPath,
535+
join(archiveRoot, 'DISCLAIMER-WIP'),
535536
join(archiveRoot, 'LICENSE'),
536537
join(archiveRoot, 'NOTICE'),
537538
join(archiveRoot, 'libexec', 'node', 'LICENSE'),

0 commit comments

Comments
 (0)