[MARTIFACT-45] detectSkip does not see the skip in deploy and install plugin when execution id configured

[jira-importer]

Niels Basjes opened MARTIFACT-45 and commented

If a module in a project has something like this then the skip is not seen (for both install and deploy plugins)

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-deploy-plugin</artifactId>
  <version>3.1.0</version>
  <executions>
    <execution>
      <id>default-deploy</id>
      <phase>deploy</phase>
      <configuration>
        <skip>true</skip>
      </configuration>
    </execution>
  </executions>
</plugin>

---

Issue Links:

• MARTIFACT-34 detect ignored modules when nexus-staging-maven-plugin skipNexusStagingDeployMojo=true

• MARTIFACT-50 add skipModules parameter

Remote Links:

• GitHub Pull Request #17
  

[jira-importer]

Niels Basjes commented

The pull request is ONLY the reproduction of this issue as an extension of the existing integration test.

[jira-importer]

Niels Basjes commented

Note. Something like this does work as expected:

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-deploy-plugin</artifactId>
  <version>3.1.0</version>
  <configuration>
    <skip>true</skip>
  </configuration>
</plugin>

 

[jira-importer]

Hervé Boutemy commented

ah, it's the explicit "default-deploy" id that causes the detection to fail: now I better understand
I'll can change priority to Minor, because you usually do not define such id, and even best practice is to just use maven.deploy.skip property