Skip to content

Built in skip properties [skipAddThirdParty and skipDownloadLicenses] of the **license-maven-plugin** are generating missmatch in the effective pom #452

Description

@tblaszlo

Affected version

1.2.1

Bug description

Built in skip properties [skipAddThirdParty and skipDownloadLicenses] of the license-maven-plugin are generating mismatch in the effective pom which is triggering module rebuild, even if reconciliation is configured to ignore these flags only when set to true.

                <plugin artifactId="license-maven-plugin" goal="add-third-party">
                    <reconciles>
                        <reconcile propertyName="skipAddThirdParty" skipValue="true"/>
                    </reconciles>
                </plugin>
                <plugin artifactId="license-maven-plugin" goal="download-licenses">
                    <reconciles>
                        <reconcile propertyName="skipDownloadLicenses" skipValue="true"/>
                    </reconciles>
                </plugin>

See relevant part of the xml samples.

buildinfo-baseline:

 <execution>
  <executionKey>third-party-license-info:add-third-party:initialize:license-maven-plugin:org.codehaus.mojo</executionKey>
  <mojoClassName>org.codehaus.mojo.license.AddThirdPartyMojo</mojoClassName>
  <properties>
    <property name="acceptPomPackaging" tracked="false">true</property>
    <property name="artifactFiltersUrl" tracked="false">null</property>
    ...
    <property name="**skipAddThirdParty**" tracked="true">**false**</property>
    <property name="sortArtifactByName" tracked="false">true</property>
    <property name="thirdPartyFilename" tracked="false">THIRD-PARTY.txt</property>
    <property name="useMissingFile" tracked="false">false</property>
    <property name="useRepositoryMissingFiles" tracked="false">true</property>
    <property name="verbose" tracked="false">false</property>
  </properties>
 </execution>

...

 <execution>
  <executionKey>third-party-license-info:download-licenses:initialize:license-maven-plugin:org.codehaus.mojo</executionKey>
  <mojoClassName>org.codehaus.mojo.license.DownloadLicensesMojo</mojoClassName>
  <properties>
   ...
    <property name="**skipDownloadLicenses**" tracked="true">**false**</property>
    <property name="socketTimeout" tracked="false">5000</property>
    <property name="sortByGroupIdAndArtifactId" tracked="false">true</property>
    <property name="useDefaultContentSanitizers" tracked="false">false</property>
    <property name="useDefaultUrlReplacements" tracked="false">false</property>
    <property name="writeCalcFile" tracked="false">false</property>
    <property name="writeExcelFile" tracked="false">false</property>
    <property name="writeVersions" tracked="false">true</property>
  </properties>
</execution>

buildinfo:

 <execution>
  <executionKey>third-party-license-info:add-third-party:initialize:license-maven-plugin:org.codehaus.mojo</executionKey>
  <mojoClassName>org.codehaus.mojo.license.AddThirdPartyMojo</mojoClassName>
  <properties>
    <property name="acceptPomPackaging" tracked="false">true</property>
    <property name="artifactFiltersUrl" tracked="false">null</property>
    ...
    <property name="**skipAddThirdParty**" tracked="true">**true**</property>
    <property name="sortArtifactByName" tracked="false">true</property>
    <property name="thirdPartyFilename" tracked="false">THIRD-PARTY.txt</property>
    <property name="useMissingFile" tracked="false">false</property>
    <property name="useRepositoryMissingFiles" tracked="false">true</property>
    <property name="verbose" tracked="false">false</property>
  </properties>
</execution>

...

 <execution>
  <executionKey>third-party-license-info:download-licenses:initialize:license-maven-plugin:org.codehaus.mojo</executionKey>
  <mojoClassName>org.codehaus.mojo.license.DownloadLicensesMojo</mojoClassName>
  <properties>
   ...
    <property name="**skipDownloadLicenses**" tracked="true">**true**</property>
    <property name="socketTimeout" tracked="false">5000</property>
    <property name="sortByGroupIdAndArtifactId" tracked="false">true</property>
    <property name="useDefaultContentSanitizers" tracked="false">false</property>
    <property name="useDefaultUrlReplacements" tracked="false">false</property>
    <property name="writeCalcFile" tracked="false">false</property>
    <property name="writeExcelFile" tracked="false">false</property>
    <property name="writeVersions" tracked="false">true</property>
  </properties>
</execution>

And the effective pom generated:
effective-pom-baseline:

   <plugin>
    <groupId>org.codehaus.mojo</groupId>
    <artifactId>license-maven-plugin</artifactId>
    <version>2.4.0</version>
    <executions>
      <execution>
        <id>third-party-license-info</id>
        <phase>initialize</phase>
        <goals>
          <goal>add-third-party</goal>
          <goal>download-licenses</goal>
        </goals>
        <configuration>
          **<skipAddThirdParty>false</skipAddThirdParty>**
          **<skipDownloadLicenses>false</skipDownloadLicenses>**
          <errorRemedy>warn</errorRemedy>
          ...
        </configuration>
      </execution>
    </executions>
   </plugin>

effective-pom:

   <plugin>
    <groupId>org.codehaus.mojo</groupId>
    <artifactId>license-maven-plugin</artifactId>
    <version>2.4.0</version>
    <executions>
      <execution>
        <id>third-party-license-info</id>
        <phase>initialize</phase>
        <goals>
          <goal>add-third-party</goal>
          <goal>download-licenses</goal>
        </goals>
        <configuration>
          **<skipAddThirdParty>true</skipAddThirdParty>**
          **<skipDownloadLicenses>true</skipDownloadLicenses>**
          <errorRemedy>warn</errorRemedy>
          ...
        </configuration>
      </execution>
    </executions>
   </plugin>

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions