From bb34952545a25aa7aa7c48ce2ca8c5686ebca0d9 Mon Sep 17 00:00:00 2001 From: Lio Fleishman Date: Mon, 3 Aug 2026 12:27:57 -0500 Subject: [PATCH] [OSSIE][NVIDIA_GSF] Rename GSF converter directory and package to NVIDIA Name the converter after the vendor that owns it rather than the product, matching how every other converter directory in the tree is named. The directory becomes converters/nvidia and the import package becomes ossie_nvidia_gsf, so the product name still appears at the point of import. Rename the distribution to apache-ossie-nvidia-gsf and the console script to ossie-nvidia-gsf, and repoint the CI workflow, itself renamed to converter-nvidia-ci.yml to preserve the converter--ci.yml convention shared by the other converters. Its check name changes accordingly. The NVIDIA_GSF vendor code in the spec's extension table is left alone, being a format identifier rather than a path. --- ...onverter-gsf-ci.yml => converter-nvidia-ci.yml} | 14 +++++++------- converters/{gsf => nvidia}/README.md | 10 +++++----- converters/{gsf => nvidia}/pyproject.toml | 6 +++--- .../src/ossie_nvidia_gsf}/__init__.py | 0 .../src/ossie_nvidia_gsf}/converter.py | 0 .../src/ossie_nvidia_gsf}/native_converter.py | 0 .../{gsf => nvidia}/tests/fixtures/sales.gsf.yaml | 0 .../tests/fixtures/sales.ossie.yaml | 0 converters/{gsf => nvidia}/tests/test_converter.py | 4 ++-- converters/{gsf => nvidia}/uv.lock | 2 +- 10 files changed, 18 insertions(+), 18 deletions(-) rename .github/workflows/{converter-gsf-ci.yml => converter-nvidia-ci.yml} (85%) rename converters/{gsf => nvidia}/README.md (97%) rename converters/{gsf => nvidia}/pyproject.toml (93%) rename converters/{gsf/src/ossie_gsf => nvidia/src/ossie_nvidia_gsf}/__init__.py (100%) rename converters/{gsf/src/ossie_gsf => nvidia/src/ossie_nvidia_gsf}/converter.py (100%) rename converters/{gsf/src/ossie_gsf => nvidia/src/ossie_nvidia_gsf}/native_converter.py (100%) rename converters/{gsf => nvidia}/tests/fixtures/sales.gsf.yaml (100%) rename converters/{gsf => nvidia}/tests/fixtures/sales.ossie.yaml (100%) rename converters/{gsf => nvidia}/tests/test_converter.py (99%) rename converters/{gsf => nvidia}/uv.lock (99%) diff --git a/.github/workflows/converter-gsf-ci.yml b/.github/workflows/converter-nvidia-ci.yml similarity index 85% rename from .github/workflows/converter-gsf-ci.yml rename to .github/workflows/converter-nvidia-ci.yml index e2f3412c..c86c873b 100644 --- a/.github/workflows/converter-gsf-ci.yml +++ b/.github/workflows/converter-nvidia-ci.yml @@ -17,19 +17,19 @@ # under the License. # -name: Converters GSF CI +name: Converters NVIDIA GSF CI on: push: branches: [ "main" ] paths: - - 'converters/gsf/**' - - '.github/workflows/converter-gsf-ci.yml' + - 'converters/nvidia/**' + - '.github/workflows/converter-nvidia-ci.yml' pull_request: branches: [ "main" ] paths: - - 'converters/gsf/**' - - '.github/workflows/converter-gsf-ci.yml' + - 'converters/nvidia/**' + - '.github/workflows/converter-nvidia-ci.yml' jobs: build: @@ -53,11 +53,11 @@ jobs: echo "${HOME}/.local/bin" >> "${GITHUB_PATH}" - name: Sync dependencies - working-directory: converters/gsf + working-directory: converters/nvidia run: | uv sync - name: Unit Tests - working-directory: converters/gsf + working-directory: converters/nvidia run: | uv run pytest diff --git a/converters/gsf/README.md b/converters/nvidia/README.md similarity index 97% rename from converters/gsf/README.md rename to converters/nvidia/README.md index 35219cc1..3c564d3b 100644 --- a/converters/gsf/README.md +++ b/converters/nvidia/README.md @@ -46,14 +46,14 @@ converter targets. ## Setup ```bash -cd converters/gsf +cd converters/nvidia uv sync ``` ## Ossie → GSF ```bash -uv run ossie-gsf export \ +uv run ossie-nvidia-gsf export \ --input ../../examples/tpcds_semantic_model.yaml \ --output tpcds.gsf.yaml \ --database-name tpcds @@ -64,7 +64,7 @@ qualified `database.schema.table` sources do not require it. One document may contain multiple databases. ```python -from ossie_gsf import convert_ossie_to_gsf +from ossie_nvidia_gsf import convert_ossie_to_gsf gsf_yaml = convert_ossie_to_gsf(ossie_yaml, database_name="tpcds") ``` @@ -72,7 +72,7 @@ gsf_yaml = convert_ossie_to_gsf(ossie_yaml, database_name="tpcds") ## GSF → Ossie ```bash -uv run ossie-gsf import \ +uv run ossie-nvidia-gsf import \ --input tpcds.gsf.yaml \ --output semantic_model.yaml \ --name tpcds @@ -82,7 +82,7 @@ uv run ossie-gsf import \ single catalog database name when there is one, otherwise `gsf_model`. ```python -from ossie_gsf import convert_gsf_to_ossie +from ossie_nvidia_gsf import convert_gsf_to_ossie ossie_yaml = convert_gsf_to_ossie(gsf_yaml, model_name="tpcds") ``` diff --git a/converters/gsf/pyproject.toml b/converters/nvidia/pyproject.toml similarity index 93% rename from converters/gsf/pyproject.toml rename to converters/nvidia/pyproject.toml index 0ea22c40..6bafb2c1 100644 --- a/converters/gsf/pyproject.toml +++ b/converters/nvidia/pyproject.toml @@ -26,7 +26,7 @@ dev = [ ] [project] -name = "apache-ossie-gsf" +name = "apache-ossie-nvidia-gsf" version = "0.1.0.dev0" description = "NVIDIA GSF <> Apache Ossie offline YAML converter" authors = [{ name = "Apache Software Foundation", email = "dev@ossie.apache.org" }] @@ -46,14 +46,14 @@ dependencies = [ ] [project.scripts] -ossie-gsf = "ossie_gsf.converter:main" +ossie-nvidia-gsf = "ossie_nvidia_gsf.converter:main" [project.urls] homepage = "https://ossie.apache.org/" repository = "https://github.com/apache/ossie/" [tool.hatch.build.targets.wheel] -packages = ["src/ossie_gsf"] +packages = ["src/ossie_nvidia_gsf"] [tool.pytest.ini_options] testpaths = ["tests"] diff --git a/converters/gsf/src/ossie_gsf/__init__.py b/converters/nvidia/src/ossie_nvidia_gsf/__init__.py similarity index 100% rename from converters/gsf/src/ossie_gsf/__init__.py rename to converters/nvidia/src/ossie_nvidia_gsf/__init__.py diff --git a/converters/gsf/src/ossie_gsf/converter.py b/converters/nvidia/src/ossie_nvidia_gsf/converter.py similarity index 100% rename from converters/gsf/src/ossie_gsf/converter.py rename to converters/nvidia/src/ossie_nvidia_gsf/converter.py diff --git a/converters/gsf/src/ossie_gsf/native_converter.py b/converters/nvidia/src/ossie_nvidia_gsf/native_converter.py similarity index 100% rename from converters/gsf/src/ossie_gsf/native_converter.py rename to converters/nvidia/src/ossie_nvidia_gsf/native_converter.py diff --git a/converters/gsf/tests/fixtures/sales.gsf.yaml b/converters/nvidia/tests/fixtures/sales.gsf.yaml similarity index 100% rename from converters/gsf/tests/fixtures/sales.gsf.yaml rename to converters/nvidia/tests/fixtures/sales.gsf.yaml diff --git a/converters/gsf/tests/fixtures/sales.ossie.yaml b/converters/nvidia/tests/fixtures/sales.ossie.yaml similarity index 100% rename from converters/gsf/tests/fixtures/sales.ossie.yaml rename to converters/nvidia/tests/fixtures/sales.ossie.yaml diff --git a/converters/gsf/tests/test_converter.py b/converters/nvidia/tests/test_converter.py similarity index 99% rename from converters/gsf/tests/test_converter.py rename to converters/nvidia/tests/test_converter.py index 29ac624d..ddda1a4b 100644 --- a/converters/gsf/tests/test_converter.py +++ b/converters/nvidia/tests/test_converter.py @@ -29,13 +29,13 @@ import pytest import yaml -from ossie_gsf.converter import ( +from ossie_nvidia_gsf.converter import ( GSFConversionError, convert_gsf_to_ossie, convert_ossie_to_gsf, main, ) -from ossie_gsf.native_converter import ( +from ossie_nvidia_gsf.native_converter import ( _SQL_TYPE_BY_OSSIE_DATATYPE, _index_native_document, _ossie_datatype, diff --git a/converters/gsf/uv.lock b/converters/nvidia/uv.lock similarity index 99% rename from converters/gsf/uv.lock rename to converters/nvidia/uv.lock index 2be98a07..87d22904 100644 --- a/converters/gsf/uv.lock +++ b/converters/nvidia/uv.lock @@ -3,7 +3,7 @@ revision = 3 requires-python = ">=3.11" [[package]] -name = "apache-ossie-gsf" +name = "apache-ossie-nvidia-gsf" version = "0.1.0.dev0" source = { editable = "." } dependencies = [