From 3a4caec16b17fb91751023e6429c7da7adbd46c1 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Wed, 8 Jul 2026 21:13:03 +0000
Subject: [PATCH] Add explicit timeouts to fetch API calls

Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
---
 .jules/sentinel.md       | 5 +++++
 scripts/sync-sources.mjs | 2 ++
 src/lib/network.ts       | 1 +
 src/lib/snap-market.ts   | 1 +
 4 files changed, 9 insertions(+)

diff --git a/.jules/sentinel.md b/.jules/sentinel.md
index b5d9250..de339c0 100644
--- a/.jules/sentinel.md
+++ b/.jules/sentinel.md
@@ -12,3 +12,8 @@
 **Vulnerability:** XSS risk via unsanitized `<` characters in `JSON.stringify` output injected into `<script type="application/ld+json">`.
 **Learning:** `JSON.stringify()` does not automatically escape `<` as `\u003c`. If dynamic or unsanitized content is serialized into a `<script>` tag via `dangerouslySetInnerHTML`, an attacker can include `</script>` to break out of the context and inject malicious scripts.
 **Prevention:** Always replace `<` with `\u003c` when injecting JSON output into script tags, e.g., `JSON.stringify(data).replace(/</g, '\\u003c')`.
+
+## 2025-07-08 - Missing Fetch Timeouts
+**Vulnerability:** Native `fetch` API calls without explicit timeouts.
+**Learning:** The native `fetch` API lacks a default timeout, which can lead to server resource exhaustion and hanging requests, particularly in Next.js server-side functions calling external APIs.
+**Prevention:** Always include an explicit timeout (e.g., using `signal: AbortSignal.timeout(TIMEOUT_MS)`) for external `fetch` calls.
diff --git a/scripts/sync-sources.mjs b/scripts/sync-sources.mjs
index 7dbc002..e0253a6 100644
--- a/scripts/sync-sources.mjs
+++ b/scripts/sync-sources.mjs
@@ -32,6 +32,7 @@ async function fetchGithubJson(url, { optional = false } = {}) {
       "X-GitHub-Api-Version": "2022-11-28",
       ...(githubToken ? { Authorization: `Bearer ${githubToken}` } : {}),
     },
+    signal: AbortSignal.timeout(15000),
   });
 
   if ((response.status === 404 || response.status === 409) && optional) {
@@ -53,6 +54,7 @@ async function fetchGithubText(url, { optional = false } = {}) {
       "X-GitHub-Api-Version": "2022-11-28",
       ...(githubToken ? { Authorization: `Bearer ${githubToken}` } : {}),
     },
+    signal: AbortSignal.timeout(15000),
   });
 
   if ((response.status === 404 || response.status === 409) && optional) {
diff --git a/src/lib/network.ts b/src/lib/network.ts
index 049cc1e..8a390b6 100644
--- a/src/lib/network.ts
+++ b/src/lib/network.ts
@@ -85,6 +85,7 @@ export async function getNetworkStatus(): Promise<NetworkStatus> {
       headers: {
         Accept: "application/json",
       },
+      signal: AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS),
     });
 
     if (!response.ok) {
diff --git a/src/lib/snap-market.ts b/src/lib/snap-market.ts
index 19b7c1a..785fbd9 100644
--- a/src/lib/snap-market.ts
+++ b/src/lib/snap-market.ts
@@ -79,6 +79,7 @@ export async function getSnapMarketData(): Promise<SnapMarketResponse> {
         "user-agent": "hypersnap.org market data checker",
       },
       next: { revalidate: SNAP_MARKET_REVALIDATE },
+      signal: AbortSignal.timeout(10000),
     });
 
     if (!response.ok) {