Skip to content

Fix reversed suggestions #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eduardbosch wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix reversed suggestions #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions library/src/main/java/com/arlib/floatingsearchview/FloatingSearchView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

/**
Expand Down Expand Up @@ -200,6 +199,7 @@ public class FloatingSearchView extends FrameLayout {
private OnSuggestionsListHeightChanged mOnSuggestionsListHeightChanged;
private long mSuggestionSectionAnimDuration;
private OnClearSearchActionListener mOnClearSearchActionListener;
private ViewTreeObserver.OnGlobalLayoutListener mOnGlobalLayoutListener;

//An interface for implementing a listener that will get notified when the suggestions
//section's height is set. This is to be used internally only.
Expand Down Expand Up @@ -1345,8 +1345,11 @@ public void swapSuggestions(final List<? extends SearchSuggestion> newSearchSugg

private void swapSuggestions(final List<? extends SearchSuggestion> newSearchSuggestions,
final boolean withAnim) {

mSuggestionsList.getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {
// Prevent calling twice for single swap
if (mOnGlobalLayoutListener != null) {
Util.removeGlobalLayoutObserver(mSuggestionsList, mOnGlobalLayoutListener);
}
mOnGlobalLayoutListener = new ViewTreeObserver.OnGlobalLayoutListener() {
@Override
public void onGlobalLayout() {
Util.removeGlobalLayoutObserver(mSuggestionsList, this);
Expand All @@ -1362,7 +1365,9 @@ public void onGlobalLayout() {
}
mSuggestionsList.setAlpha(1);
}
});
};
mSuggestionsList.getViewTreeObserver().addOnGlobalLayoutListener(mOnGlobalLayoutListener);

mSuggestionsList.setAdapter(mSuggestionsAdapter);//workaround to avoid list retaining scroll pos
mSuggestionsList.setAlpha(0);
mSuggestionsAdapter.swapData(newSearchSuggestions);
Expand Down