-
Notifications
You must be signed in to change notification settings - Fork 0
Fix CI failures and TypeScript deprecation warnings #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
42af756
1a937ce
6cf9826
4ab9fe8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ jobs: | |
|
|
||
| - name: Get php version | ||
| id: versions | ||
| uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2 | ||
| uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
python - <<'PY'
import pathlib, re
pattern = re.compile(r'nextcloud-ci/nextcloud-version-matrix@([0-9a-f]+)')
for wf in pathlib.Path(".github/workflows").glob("*.yml"):
text = wf.read_text(encoding="utf-8")
for m in pattern.finditer(text):
sha = m.group(1)
print(f"{wf}: sha={sha} length={len(sha)}")
PYRepository: ashcoft/nextcloud-cad-viewer Length of output: 928 Pin uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2🤖 Prompt for AI Agents
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P0: Invalid commit SHA: the pinned hash is only 37 characters instead of the required 40 for a valid Git SHA-1. This will cause the workflow to fail at runtime. Additionally, the organization was changed from Prompt for AI agents |
||
|
|
||
| - name: Set up php${{ steps.versions.outputs.php-min }} | ||
| uses: shivammathur/setup-php@7c071dfe9dc99bdf297fa79cb49ea005b9fcadbc # 2.37.1 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ jobs: | |
|
|
||
| - name: Get version matrix | ||
| id: versions | ||
| uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2 | ||
| uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P0: Invalid commit SHA: the pinned hash is 37 characters instead of the required 40 for a valid SHA-1. This will cause the workflow to fail when GitHub tries to resolve the action. Additionally, verify that the repository Prompt for AI agents |
||
|
|
||
| php-lint: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,7 @@ jobs: | |
|
|
||
| - name: Get php version | ||
| id: php_versions | ||
| uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2 | ||
| uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P0: Invalid commit SHA: the pinned hash Prompt for AI agents |
||
|
|
||
| - name: Set up php | ||
| uses: shivammathur/setup-php@7c071dfe9dc99bdf297fa79cb49ea005b9fcadbc # v2.37.1 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ jobs: | |
|
|
||
| - name: Get php version | ||
| id: versions | ||
| uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2 | ||
| uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: Invalid commit SHA: the pinned hash is 37 characters instead of the required 40 for a valid SHA-1. GitHub Actions will fail to resolve this action reference. Additionally, the organization was changed from Prompt for AI agents |
||
|
|
||
| - name: Check enforcement of minimum PHP version ${{ steps.versions.outputs.php-min }} in phpstan.neon | ||
| run: "grep 'min: ${{ steps.versions.outputs.php-min }}' phpstan.neon" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ jobs: | |
|
|
||
| - name: Get version matrix | ||
| id: versions | ||
| uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2 | ||
| uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: Invalid commit SHA for action pin: the hash is only 37 characters instead of the required 40. GitHub Actions will fail to resolve this reference, breaking the Prompt for AI agents |
||
|
|
||
| changes: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -101,7 +101,7 @@ jobs: | |
| if: ${{ env.APP_NAME == '' }} | ||
| run: | | ||
| # Split and keep last | ||
| echo "APP_NAME=${GITHUB_REPOSITORY##*/}" >> $GITHUB_ENV | ||
| echo "APP_NAME=cad_viewer" >> $GITHUB_ENV | ||
|
|
||
| - name: Checkout server | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ jobs: | |
|
|
||
| - name: Get version matrix | ||
| id: versions | ||
| uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2 | ||
| uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: Invalid commit SHA: the pinned hash is only 37 characters instead of the required 40. This will prevent GitHub Actions from resolving the action, breaking CI. Please verify and use the correct full SHA for Prompt for AI agents |
||
|
|
||
| changes: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -81,7 +81,7 @@ jobs: | |
| if: ${{ env.APP_NAME == '' }} | ||
| run: | | ||
| # Split and keep last | ||
| echo "APP_NAME=${GITHUB_REPOSITORY##*/}" >> $GITHUB_ENV | ||
| echo "APP_NAME=cad_viewer" >> $GITHUB_ENV | ||
|
|
||
| - name: Checkout server | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ jobs: | |
|
|
||
| - name: Get version matrix | ||
| id: versions | ||
| uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2 | ||
| uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P0: Invalid commit SHA pinning — the hash Prompt for AI agents |
||
|
|
||
| - name: Check enforcement of minimum PHP version ${{ steps.versions.outputs.php-min }} in psalm.xml | ||
| run: grep 'phpVersion="${{ steps.versions.outputs.php-min }}' psalm.xml | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ jobs: | |
|
|
||
| - name: Get php version | ||
| id: versions | ||
| uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2 | ||
| uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P0: Invalid commit SHA: the pinned hash is 37 characters instead of the required 40 for a SHA-1. GitHub Actions will fail to resolve this action reference, breaking the workflow. Verify the correct full commit hash for the target repository and organization. Prompt for AI agents |
||
|
|
||
| - name: Check enforcement of minimum PHP version ${{ steps.versions.outputs.php-min }} in psalm.xml | ||
| run: grep 'phpVersion="${{ steps.versions.outputs.php-min }}' psalm.xml | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ jobs: | |
|
|
||
| - name: Get php version | ||
| id: versions | ||
| uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2 | ||
| uses: nextcloud-ci/nextcloud-version-matrix@9196b025f1873130088b297995a229558ddba # v1.3.2 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Description: Fetch the correct commit hash for nextcloud-ci/nextcloud-version-matrix@v1.3.2
# Fetch the commit SHA for the v1.3.2 tag
gh api repos/nextcloud-ci/nextcloud-version-matrix/git/ref/tags/v1.3.2 --jq '.object.sha'Repository: ashcoft/nextcloud-cad-viewer Length of output: 229 Fix the truncated action SHA in
🤖 Prompt for AI Agents
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: Invalid commit SHA — the pinned hash is only 37 characters instead of the required 40. GitHub Actions cannot resolve a truncated SHA, so this workflow will fail at the "Get php version" step. Verify the correct full commit hash for Prompt for AI agents |
||
|
|
||
| - name: Set up php${{ steps.versions.outputs.php-min }} | ||
| uses: shivammathur/setup-php@7c071dfe9dc99bdf297fa79cb49ea005b9fcadbc # v2.37.1 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ | ||
| Upstream-Name: nextcloud-cad-viewer | ||
| Upstream-Contact: CAD Viewer Contributors | ||
| Upstream-Name: cad_viewer | ||
| Source: https://github.com/ashcoft/nextcloud-cad-viewer | ||
|
Comment on lines
+2
to
3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Description: Check if the GitHub repository name has changed to match the new app ID
# Fetch the repository information
gh repo view ashcoft/nextcloud-cad-viewer --json name,nameWithOwner 2>&1
# Also check if a repository with the new name exists
gh repo view ashcoft/cad_viewer --json name,nameWithOwner 2>&1 || echo "Repository ashcroft/cad_viewer does not exist"Repository: ashcoft/nextcloud-cad-viewer Length of output: 289 Clarify 🤖 Prompt for AI Agents |
||
|
|
||
| Files: * | ||
| Copyright: 2026 CAD Viewer Contributors | ||
| Copyright: 2024 ashcoft | ||
| License: MIT | ||
|
|
||
| Files: .github/workflows/* | ||
| Copyright: 2023-2024 Nextcloud GmbH and Nextcloud contributors | ||
| License: MIT | ||
|
Comment on lines
5
to
11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Description: Search for references to CC0 in the repository to identify which files might use this license
# Search for CC0 references in documentation and metadata
rg -i 'CC0' --type-add 'config:*.{json,xml,md,txt,yml,yaml}' --type config -C 2
# Check if there are any SPDX headers indicating CC0
rg 'SPDX-License-Identifier.*CC0' -C 2Repository: ashcoft/nextcloud-cad-viewer Length of output: 4978 .reuse/dep5 needs CC0-1.0 attribution for LICENSES/CC0-1.0.txt
🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| Creative Commons Legal Code | ||
|
|
||
| CC0 1.0 Universal | ||
|
|
||
| CREATIVE COMMONS CORPORATION IS NOT A LAW FIRM AND DOES NOT PROVIDE | ||
| LEGAL SERVICES. DISTRIBUTION OF THIS DOCUMENT DOES NOT CREATE AN | ||
| ATTORNEY-CLIENT RELATIONSHIP. CREATIVE COMMONS PROVIDES THIS | ||
| INFORMATION ON AN "AS-IS" BASIS. CREATIVE COMMONS MAKES NO | ||
| WARRANTIES REGARDING THE USE OF THIS DOCUMENT OR THE INFORMATION OR | ||
| WORKS PROVIDED HEREUNDER, AND DISCLAIMS LIABILITY FOR DAMAGES | ||
| RESULTING FROM THE USE OF THIS DOCUMENT OR THE INFORMATION OR WORKS | ||
| PROVIDED HEREUNDER. | ||
|
|
||
| Statement of Purpose | ||
|
|
||
| The laws of most jurisdictions throughout the world automatically confer | ||
| exclusive Copyright and Related Rights (defined below) upon the creator | ||
| and subsequent owner(s) (each and all, an "owner") of an original work of | ||
| authorship and/or a database (each, a "Work"). | ||
|
|
||
| Certain owners wish to permanently relinquish those rights to a Work for | ||
| the purpose of contributing to a commons of creative, cultural and | ||
| scientific works ("Commons") that the public can reliably and without fear | ||
| of later claims of infringement build upon, modify, incorporate in other | ||
| works, reuse and redistribute as freely as possible in any form whatsoever | ||
| and for any purposes, including without limitation commercial purposes. | ||
| These owners may contribute to the Commons to promote the ideal of a free | ||
| culture and the further production of creative, cultural and scientific | ||
| works, or to gain reputation or greater distribution for their Work in | ||
| part through the use and efforts of others. | ||
|
|
||
| For these and/or other purposes and motivations, and without any | ||
| expectation of additional consideration or compensation, the person | ||
| associating CC0 with a Work (the "Affirmer"), to the extent that he or she | ||
| is the owner of Copyright and Related Rights in the Work, voluntarily | ||
| elects to apply CC0 to the Work and publicly distribute the Work under its | ||
| terms, with knowledge of his or her Copyright and Related Rights in the | ||
| Work and the meaning and intended legal effect of CC0 on those rights. | ||
|
|
||
| 1. Copyright and Related Rights. A Work made available under CC0 may be | ||
| protected by copyright and related or neighboring rights ("Copyright and | ||
| Related Rights"). Copyright and Related Rights include, but are not | ||
| limited to, the following: | ||
|
|
||
| i. the right to reproduce, adapt, distribute, perform, display, | ||
| communicate, and translate a Work; | ||
| ii. moral rights retained by the original author(s) and/or performer(s); | ||
| iii. publicity and privacy rights pertaining to a person's image or | ||
| likeness depicted in a Work; | ||
| iv. rights protecting against unfair competition in regards to a Work, | ||
| subject to the limitations in paragraph 4(a), below; | ||
| v. rights protecting the extraction, dissemination, use and reuse of | ||
| data in a Work; | ||
| vi. database rights (such as those arising under Directive 96/9/EC of the | ||
| European Parliament and of the Council of 11 March 1996 on the legal | ||
| protection of databases, and under any national implementation | ||
| thereof, including any amended or successive version of such | ||
| directive); and | ||
| vii. other similar, equivalent or corresponding rights throughout the | ||
| world based on applicable law or treaty, and any national | ||
| implementations thereof. | ||
|
|
||
| 2. Waiver. To the greatest extent permitted by, but not in contravention | ||
| of, applicable law, Affirmer hereby overtly, fully, permanently, | ||
| irrevocably and unconditionally waives, abandons, and relinquishes all of | ||
| Affirmer's Copyright and Related Rights and associated claims and causes | ||
| of action, whether now known or unknown (including existing as well as | ||
| future claims and causes of action), in the Work (i) in all territories | ||
| worldwide, (ii) for the maximum duration provided by applicable law or | ||
| treaty (including future time extensions), (iii) in any current or future | ||
| medium and for any number of copies, and (iv) for any purpose whatsoever, | ||
| including without limitation commercial, advertising or promotional | ||
| purposes (the "Waiver"). Affirmer makes the Waiver for the benefit of each | ||
| member of the public at large and to the detriment of Affirmer's heirs and | ||
| successors, fully intending that such Waiver shall not be subject to | ||
| revocation, rescission, cancellation, termination, or any other legal or | ||
| equitable action to disrupt the quiet enjoyment of the Work by the public | ||
| as contemplated by Affirmer's express Statement of Purpose. | ||
|
|
||
| 3. Public License Fallback. Should any part of the Waiver for any reason | ||
| be judged legally invalid or ineffective under applicable law, then the | ||
| Waiver shall be preserved to the maximum extent permitted taking into | ||
| account Affirmer's express Statement of Purpose. In addition, to the | ||
| extent the Waiver is so judged Affirmer hereby grants to each affected | ||
| person a royalty-free, non transferable, non sublicensable, non exclusive, | ||
| irrevocable and unconditional license to exercise Affirmer's Copyright and | ||
| Related Rights in the Work (i) in all territories worldwide, (ii) for the | ||
| maximum duration provided by applicable law or treaty (including future | ||
| time extensions), (iii) in any current or future medium and for any number | ||
| of copies, and (iv) for any purpose whatsoever, including without | ||
| limitation commercial, advertising or promotional purposes (the | ||
| "License"). The License shall be deemed effective as of the date CC0 was | ||
| applied by Affirmer to the Work. Should any part of the License for any | ||
| reason be judged legally invalid or ineffective under applicable law, such | ||
| partial invalidity or ineffectiveness shall not invalidate the remainder | ||
| of the License, and in such case Affirmer hereby affirms that he or she | ||
| will not (i) exercise any of his or her remaining Copyright and Related | ||
| Rights in the Work or (ii) assert any associated claims and causes of action | ||
| with respect to the Work, in either case contrary to Affirmer's express | ||
| Statement of Purpose. | ||
|
|
||
| 4. Limitations and Disclaimers. | ||
|
|
||
| a. No trademark or patent rights held by Affirmer are waived, abandoned, | ||
| surrendered, licensed or otherwise affected by this document. | ||
| b. Affirmer offers the Work as-is and makes no representations or | ||
| warranties of any kind concerning the Work, express, implied, | ||
| statutory or otherwise, including without limitation warranties of | ||
| title, merchantability, fitness for a particular purpose, non | ||
| infringement, or the absence of latent or other defects, accuracy, or | ||
| the present or absence of errors, whether or not discoverable, all to | ||
| the greatest extent permitted by applicable law. | ||
| c. Affirmer disclaims responsibility for clearing rights of other persons | ||
| that may apply to the Work or any use thereof, including without | ||
| limitation any person's Copyright and Related Rights in the Work. | ||
| Further, Affirmer disclaims responsibility for obtaining any necessary | ||
| consents, permissions or other rights required for any use of the | ||
| Work. | ||
| d. Affirmer understands and acknowledges that Creative Commons is not a | ||
| party to this document and has no duty or obligation with respect to | ||
| this CC0 or use of the Work. |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P0: Hardcoding
APP_NAME=cad_viewerbreaks this workflow. The current repository is checked out intohost/apps/spreed(see the "Checkout spreed app" steps), but subsequent steps referencehost/apps/${{ env.APP_NAME }}which now resolves tohost/apps/cad_viewer— a directory that doesn't exist. Either the checkout paths need to be updated tohost/apps/cad_viewerorAPP_NAMEshould matchspreed.Prompt for AI agents