Skip to content

[Bug report] Parallel sampler hanging on shutdown #210

@joel99

Description

@joel99

Hi,

I recently started using this wonderful library, but have been occasionally experiencing a small quality-of-life issue where parallel.base.ParallelSamplerBase.shutdown hangs after all the workers have finished, but the worker processes don't get joined. (I'm using the GPUSampler for basic, 1-GPU, multi-worker training.) Based on this SO post and seeing some other drain statements in the file, I think adding the following to .shutdown() patches the issue:

drain_queue(self.traj_infos_queue)
drain_queue(self.eval_traj_infos_queue)

Hope this means something to you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions