CI failures with dev numpy and astropy

[larrybradley]

The TestRectanglePixelRegion::test_as_mpl_selector test is failing in CI with devdeps (dev numpy and astropy) with a ZeroDivisionError: float division (e.g., see https://github.com/astropy/regions/runs/4734505137?check_suite_focus=true#step:6:216).

I tested this locally with dev astropy and numpy 1.22.0 and the tests pass, so the issue may be with numpy dev.

ping @dhomeier, @astrofrog

[larrybradley]

Related to as_mpl_selector, matplotlib 3.5.0 deprecated rectprops, which has been renamed props. We could bump the minimum mpl version to 3.5.0 and change the keyword name, or we could add a mpl version check and use rectprops for mpl < 3.5.0 and props for >= 3.5.0.

Currently these mpl deprecation warnings are being filtered:

• https://github.com/astropy/regions/blob/main/regions/shapes/tests/test_ellipse.py#L99
• https://github.com/astropy/regions/blob/main/regions/shapes/tests/test_rectangle.py#L103

[dhomeier]

The TestRectanglePixelRegion::test_as_mpl_selector test is failing in CI with devdeps (dev numpy and astropy) with a ZeroDivisionError: float division (e.g., see https://github.com/astropy/regions/runs/4734505137?check_suite_focus=true#step:6:216).

I tested this locally with dev astropy and numpy 1.22.0 and the tests pass, so the issue may be with numpy dev.

Tested on macOS with astropy and numpy dev, I could not reproduce this either. And I am struggling to make sense of the backtrace

E               pytest.PytestUnraisableExceptionWarning: Exception ignored in: 'regions._geometry.elliptical_overlap.elliptical_overlap_single_subpixel'
E               
E               Traceback (most recent call last):
E                 File "/home/runner/work/regions/regions/.tox/py39-test-alldeps-devdeps/lib/python3.9/site-packages/regions/shapes/ellipse.py", line 170, in to_mask
E                   fraction = elliptical_overlap_grid(xmin, xmax, ymin, ymax, nx, ny,
E               ZeroDivisionError: float division

Naturally, TestRectanglePixelRegion is not running any tests on EllipsePixelRegion, and RectanglePixelRegion is not using elliptical_overlap_grid anywhere, so how can this code be reached from that test?

[dhomeier]

We could bump the minimum mpl version to 3.5.0 and change the keyword name, or we could add a mpl version check and use rectprops for mpl < 3.5.0 and props for >= 3.5.0.

The current minimum version is 3.1, maybe a bit to big of a jump?
I can actually incorporate the version check relatively easily into #392 (which I had almost forgotten about).

[larrybradley]

Yes, I agree. 👍 to adding the version check in #392.

[larrybradley]

btw, I can't reproduce this error with dev numpy (1.23.0.dev0+321.g81c5acfed) and astropy (5.1.dev385+g5b6888e17) either.

[dhomeier]

Is there a test setup with oldest dependencies (or any matplotlib < 3.5) left now?

[pllim]

The CI is using "nightly" numpy (by nightly, they mean weekly), not latest dev. To really try to reproduce this, are you using tox as well? And who knows what Actions is caching around.

If that ZeroDivisionError: float division isn't something you worry about, pytest.mark.filterwarnings(...) on that one test might do the trick.

[larrybradley]

Yes, I'm testing locally with tox -e test-alldeps-devdeps and everything passes.

[larrybradley]

I just switched CI from Azure to Actions, so this test has never passed in Actions.

[larrybradley]

The only difference is that Actions is running tox -e test-alldeps-devdeps on ubuntu-latest and I'm on macos.

[dhomeier]

If that ZeroDivisionError: float division isn't something you worry about, pytest.mark.filterwarnings(...) on that one test might do the trick.

But on which one should we put it, if test_as_mpl_selector is reported as failing, and the ZeroDivisionError is raised on a call that may be run somewhere in test_ellipse? Don't think there should be a zero division occurring as well.

[larrybradley]

Interestingly, the devdeps test passes with macos-latest (instead of ubuntu-latest):
#417

[larrybradley]

Also passes with windows-latest. Only ubuntu-latest fails. 🤷