chore: re-use upgradeEndResponse struct

Author: nozols

lib/clusters/ota.js

@@ -109,6 +109,17 @@ const IMAGE_BLOCK_RESPONSE = {
   },
 };
 
+const UPGRADE_END_RESPONSE = {
+  id: 0x0007,
+  args: {
+    manufacturerCode: ZCLDataTypes.uint16,
+    imageType: ZCLDataTypes.uint16,
+    fileVersion: ZCLDataTypes.uint32,
+    currentTime: ZCLDataTypes.uint32,
+    upgradeTime: ZCLDataTypes.uint32,
+  },
+};
+
 // ============================================================================
 // Commands
 // ============================================================================
@@ -210,7 +221,11 @@ const COMMANDS = {
     response: IMAGE_BLOCK_RESPONSE,
   },
 
-  imageBlockResponse: IMAGE_BLOCK_RESPONSE,
+  imageBlockResponse: { // Mandatory
+    ...IMAGE_BLOCK_RESPONSE,
+    direction: Cluster.DIRECTION_SERVER_TO_CLIENT,
+    frameControl: ['directionToClient', 'clusterSpecific', 'disableDefaultResponse'],
+  },
 
   // Sent by the client when it has completed downloading an image. The status
   // value SHALL be SUCCESS, INVALID_IMAGE, REQUIRE_MORE_IMAGE, or ABORT.
@@ -222,32 +237,17 @@ const COMMANDS = {
       imageType: ZCLDataTypes.uint16,
       fileVersion: ZCLDataTypes.uint32,
     },
-    response: {
-      id: 0x0007,
-      args: {
-        manufacturerCode: ZCLDataTypes.uint16,
-        imageType: ZCLDataTypes.uint16,
-        fileVersion: ZCLDataTypes.uint32,
-        currentTime: ZCLDataTypes.uint32,
-        upgradeTime: ZCLDataTypes.uint32,
-      },
-    },
+    response: UPGRADE_END_RESPONSE,
   },
 
   // --- Server to Client Commands ---
 
   // Response to the Upgrade End Request, indicating when the client should upgrade
   // to the new image.
   upgradeEndResponse: { // Mandatory
-    id: 0x0007,
+    ...UPGRADE_END_RESPONSE,
     direction: Cluster.DIRECTION_SERVER_TO_CLIENT,
-    args: {
-      manufacturerCode: ZCLDataTypes.uint16,
-      imageType: ZCLDataTypes.uint16,
-      fileVersion: ZCLDataTypes.uint32,
-      currentTime: ZCLDataTypes.uint32,
-      upgradeTime: ZCLDataTypes.uint32,
-    },
+    frameControl: ['directionToClient', 'clusterSpecific', 'disableDefaultResponse'],
   },
 
   // Client requests a device specific file such as security credential,