-
Notifications
You must be signed in to change notification settings - Fork 97
Tags containing ":" or "-" for example are not matched properly #353
Description
Edit by @rsese to flesh out issue template
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
XML tags containing ":" are not matched properly.
As you can see, the closing tag was mismatched. It should have underlined the last tag, not the one it did.
Steps to Reproduce
atom --safe:
- Create
test.xmlwith this content:
<?xml version="1.0" encoding="UTF-8"?>
<absolutelayout row="0">
<c:Card>
<c:Card.content>
<Label text="Some text" />
</c:Card.content>
</c:Card>
</absolutelayout>- Put the cursor on
<c:Card>on line 3
Expected behavior: [What you expect to happen]
Expect </c:Card> on line 7 to be highlighted.
Actual behavior: [What actually happens]
</c:Card.content> on line 6 is highlighted.
Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions
atom -v
Atom : 1.30.0-dev-ea9b7cee4
Electron: 2.0.3
Chrome : 61.0.3163.100
Node : 8.9.3
macOS 10.12.6
Additional Information
If you remove the : in <c:Card> and </c:Card>, the tags highlight correctly.
Similar/same issue with camelCase? #388
As you can see, the closing tag was mismatched. It should have underlined the last tag, not the one it did.
I know this in not common tag-ing for XML but when working with NativeScript it's quite common.
Versions:
Atom: 1.29.0-beta0
bracket-matcher: 0.89.2
