`Save as HTML` and `Copy as HTML` stopped working in 1.32.0 with files that have fenced code blocks

[SebDeclercq]

Edits by @rsese to add new details based on #552 (comment)

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

The "Save As HTML" and "Copy As HTML" functionalities in the MarkDown preview doesn't work anymore if your file has a fenced code block. It seems that the problem began just after the update to v. 1.32.2 1.32.0 and the restart of Atom. atom/atom#17985 perhaps related?

Steps to Reproduce

1. Open a Markdown file, or create new - the file must have a fenced code block e.g.

# Hello World

```
console.log();
```

2. Ctrl + Shift + M
3. Ctrl + Shift + S (or Ctrl + C for "Copy As HTML")
4. Select file
5. Click Save

Expected behavior:

HTML file get saved and opened in new pane in Atom.

ctrlc-c or right-clicking the preview pane and selecting Copy As HTML will copy the preview in HTML for pasting.

Actual behavior:

Files is not saved nor opened. The save as dialog opens but nothing is saved.

ctrlc-c or right-clicking the preview pane and selecting Copy As HTML doesn't do anything.

Reproduces how often:

Every time if the file has a fenced code block

Versions

Atom    : 1.32.2
Electron: 2.0.9
Chrome  : 61.0.3163.100
Node    : 8.9.3

Additional Information

Last worked in 1.31.2 so maybe atom/atom#17985 is related?

This issue appears to be the exact replica of this old issue : #524

[rsese]

Thanks for opening a new issue 👍

I was unable to reproduce on 1.32.2 with macOS 10.12.6. What operating system are you running? Also tried on Windows 10 but couldn't reproduce there either.

Can you also open the keybinding resolver and share a screenshot of what you see when you try to ctrl+shift+s or ctrl+c from the preview pane?

[SebDeclercq]

I'm on Windows 10.

Here are the screenshots :

Ctrl+Shift+S

Ctrl-C

Note that I also updated git-plus before restarting Atom.

Note that using the context menu with right click and select "Save As HTML" or "Copy As HTML" does not work either.

[rsese]

Thanks for the screenshots, they look correct so not sure why nothing's happening with those commands 🤔

And it's just those commands with Markdown Preview that's not working? E.g. does ctrl-shift-s work in the Markdown file itself rather than the preview pane to "Save As" or does that also not work?

If you temporarily reset to factory defaults, does that make any difference?

[mselseth]

Same issue. Unable to save html file from md file. md file created in atom.
used save as from file menu, tried Packages -> markdown-to-html -> Toggle.
No success.
The md preview works fine.
Running ubuntu 18.10.
Any workaround?

[mselseth]

Tried a variation. From test.md file, attempted to do a save as test.html extension, got an exception, known issue reported under:
huangjinlin/atom-markdown-to-html#1

Ubuntu 18.10

If I run atom with sudo, creates the html file but is a protected file, still cannot view in Chromium browser.

[emorima]

Same issue, unable to save some md files to html files.

And I realized that these files unable to save are included fenced code blocks starting with ``` .

I replaced ``` to div tag, then able to save html files.

same as me?

[SebDeclercq]

Yep, I tried without the triple backticks and it worked as expected.

[rsese]

Ahhh ok, I can reproduce now with just:

# Hello World

```
console.log();
```

Looks like this stopped working in 1.32.0 and worked in 1.32.11.31.2 - I've updated the issue with these details.