From d53fd4eb033648136eda4052dae65155afba41b2 Mon Sep 17 00:00:00 2001 From: amna-khan Date: Wed, 17 May 2023 14:10:44 +0100 Subject: [PATCH 1/3] new line was needed as per requirement of input file syntax --- moose/kernels.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/moose/kernels.py b/moose/kernels.py index 7eb490f..ef7f58d 100644 --- a/moose/kernels.py +++ b/moose/kernels.py @@ -158,7 +158,7 @@ def __str__(self): string = f'[{self.name}]\n' string += f'type={self.aux_kernel_type.name}\n' string += f'variable={self.variable.name}\n' - string += f'{self.function.__str__()}' + string += f'{self.function.__str__()}\n' string += f'args={self.args.name}\n' string += '[]\n' return string From edc79fdc4733911c50a4bac38fe4d93a07d4ab87 Mon Sep 17 00:00:00 2001 From: amna-khan Date: Wed, 17 May 2023 14:12:58 +0100 Subject: [PATCH 2/3] f'function' also needed an equals sign as per the required syntax --- moose/kernels.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/moose/kernels.py b/moose/kernels.py index ef7f58d..7b5e4c3 100644 --- a/moose/kernels.py +++ b/moose/kernels.py @@ -158,7 +158,7 @@ def __str__(self): string = f'[{self.name}]\n' string += f'type={self.aux_kernel_type.name}\n' string += f'variable={self.variable.name}\n' - string += f'{self.function.__str__()}\n' + string += f'function={self.function.__str__()}\n' string += f'args={self.args.name}\n' string += '[]\n' return string From 2476dc18778c00d8475ca7590e1d35960346c940 Mon Sep 17 00:00:00 2001 From: amna-khan Date: Thu, 18 May 2023 18:19:02 +0100 Subject: [PATCH 3/3] the variable mesh is defined within the if statements inside the add_mesh_object method, but if none of the conditions are met, the variable remains undefined. Therefore, when you try to assign mesh to self.mesh_objects[name], it raises an UnboundLocalError. --- moose/mesh.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/moose/mesh.py b/moose/mesh.py index daaa5a2..b8a28ea 100644 --- a/moose/mesh.py +++ b/moose/mesh.py @@ -88,11 +88,14 @@ def __str__(self): def add_mesh_object(self, name = "", type = None, **kwargs): if name in self.mesh_objects.keys(): print (f'name {name} already in use') - + + mesh = None # Add a default value for the 'mesh' variable + if type == MeshObjectTypes.FileMeshGenerator: mesh = FileMeshGenerator(name=name, **kwargs) elif type == MeshObjectTypes.TransformGenerator: mesh = TransformGenerator(name=name, **kwargs) - self.mesh_objects[name] = mesh - \ No newline at end of file + if mesh is not None: + self.mesh_objects[name] = mesh +