From 3009996627a7a290eba3f68175cf275a28529840 Mon Sep 17 00:00:00 2001 From: Isaac Duarte <31712685+Isaac-Duarte@users.noreply.github.com> Date: Sun, 15 Nov 2026 08:09:23 -0700 Subject: [PATCH] arm64: dts: apple: t6050-j714s: Add the left-front router's DP IN interrupts The left-front port's USB4 router (acio1) came with the port's USB4 support, but without the DP IN interrupts that the right port's router (acio2) has. With no "dpinN" interrupt, the router driver polls a mapped DP IN's status every 20 ms instead; the interrupt and the poll run the same handler. This is not a functional fix: with the interrupts, hot plug and IRQ_HPD events arrive without the up to 20 ms poll delay, and there is no idle poll per mapped DP IN. Give acio1 the four DP IN interrupts, as acio2 has. The numbers are those of atc1-dpin0..3 in the T6050 inventory and of J716c's acio1, and follow acio2's, 32 lower like the rest of the router's interrupts. The DP IN blocks there sit at the offsets the driver maps from the router's "rc" region. The display side is already in place: dcpext0 and dcpext2 have routes to this port with its DP IN crossbar controls (typec1-dpin0..3 on atc1_dpxbar). Say in the file's header that the left-front port carries DP tunnels too. Signed-off-by: Isaac Duarte <31712685+Isaac-Duarte@users.noreply.github.com> --- .../boot/dts/apple/t6050-j714s-display.dtsi | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/apple/t6050-j714s-display.dtsi b/arch/arm64/boot/dts/apple/t6050-j714s-display.dtsi index f14c7ab163e31..633b7b6d3cb23 100644 --- a/arch/arm64/boot/dts/apple/t6050-j714s-display.dtsi +++ b/arch/arm64/boot/dts/apple/t6050-j714s-display.dtsi @@ -1,11 +1,11 @@ // SPDX-License-Identifier: GPL-2.0+ OR MIT /* - * J714s external displays: DisplayPort alt mode on the left-front and right ports and USB4 - * DisplayPort tunnels on the right port. dcpext0 and dcpext2 drive the routes; dcpext1 and - * dcpext3 are their pairs for modes that need two pipelines. The left-back port (ATC0) is the - * debug port and is not described. Addresses and interrupts are from the J714sAP ADT. The boot - * loader hands each engine over: it enables the engine, its mailbox and DARTs, publishes its - * bandwidth scratch and adds its display DART to the display subsystem. + * J714s external displays: DisplayPort alt mode and USB4 DisplayPort tunnels on the left-front + * and right ports. dcpext0 and dcpext2 drive the routes; dcpext1 and dcpext3 are their pairs for + * modes that need two pipelines. The left-back port (ATC0) is the debug port and is not + * described. Addresses and interrupts are from the J714sAP ADT. The boot loader hands each engine + * over: it enables the engine, its mailbox and DARTs, publishes its bandwidth scratch and adds its + * display DART to the display subsystem. */ &dcpext1 { @@ -242,6 +242,13 @@ interrupt-names = "dpin0", "dpin1", "dpin2", "dpin3"; }; +/* The left-front router's DP IN interrupts (atc1-dpin0..3, as in the T6050 inventory and J716c) */ +&acio1 { + interrupts = , , + , ; + interrupt-names = "dpin0", "dpin1", "dpin2", "dpin3"; +}; + /* The right router's suppliers, disabled in the inventory */ &ps_atc2_cio { status = "okay";