From e2fac9f101ff54aa0e78d6c5015705f8d3a26955 Mon Sep 17 00:00:00 2001 From: Ryan Murray Date: Fri, 20 Nov 2026 01:22:17 +1100 Subject: [PATCH] arm64: dts: apple: t8132-laptop: describe the MagSafe 3 PD controller The M4 laptops (J604, J713, J715) have a third SN201202x on nub-spmi-a0 for the MagSafe 3 port (hpm5). It is not described, so there is no Type-C port and no tps6598x power supply for MagSafe; only the SMC sees the charger. Each board's ADT gives the same values: SID 8 on nub-spmi-a0, event, sleep and wake interrupts 63, 69 and 71 (the order of hpm0's 11, 17, 19), port-type 0x11, and features-supported <3> ("Power In" only). Add it once to t8132-laptop.dtsi, which all three include, with the T8132 compatible (selection is polled, event/sleep/wake use interrupts), no connector node (no USB data path) and apple,no-liquid-detection, as the J714s and the J815 MagSafe nodes do. The J604's comment that said hpm5 is not wired now points at the shared node. The desktops (J623, J624, J773g) do not include t8132-laptop.dtsi and build to identical DTBs. The node follows the J815 MagSafe node by Nick (m0d16l14n1) and the J714s one. Signed-off-by: Ryan Murray --- arch/arm64/boot/dts/apple/t8132-j604.dts | 2 +- arch/arm64/boot/dts/apple/t8132-laptop.dtsi | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/apple/t8132-j604.dts b/arch/arm64/boot/dts/apple/t8132-j604.dts index 0bbf299e6afca..9bf5f08b5289b 100644 --- a/arch/arm64/boot/dts/apple/t8132-j604.dts +++ b/arch/arm64/boot/dts/apple/t8132-j604.dts @@ -199,7 +199,7 @@ label = "USB-C Left Rear"; }; -/* hpm3 is ATC3's port controller; hpm5, the MagSafe port's, is not wired. */ +/* hpm3 is ATC3's port controller. The MagSafe port's, hpm5, is in t8132-laptop.dtsi. */ &nub_spmi_a1 { status = "okay"; diff --git a/arch/arm64/boot/dts/apple/t8132-laptop.dtsi b/arch/arm64/boot/dts/apple/t8132-laptop.dtsi index c6a1a5ee78297..23b87b0b64e31 100644 --- a/arch/arm64/boot/dts/apple/t8132-laptop.dtsi +++ b/arch/arm64/boot/dts/apple/t8132-laptop.dtsi @@ -156,3 +156,23 @@ spi-cs-hold-delay-ns = <20>; status = "okay"; }; + +/* + * The MagSafe 3 port's PD controller, on nub-spmi-a0 next to ATC0 and ATC1's + * (SID 8, port-type 0x11, the same in each laptop's ADT). It has no USB data + * path, so it gets no connector node; tipd registers a Type-C port and a power + * supply for it. Its event, sleep and wake interrupts are 63, 69 and 71 in the + * same order as hpm0's. Its ADT features-supported is <3>, "Power In" only: no + * liquid detection. + */ +&nub_spmi_a0 { + hpm5: usb-pd@8 { + compatible = "apple,t8132-sn201202x", "apple,sn201202x"; + reg = <0x8 SPMI_USID>; + interrupts = <63 IRQ_TYPE_EDGE_RISING>, + <69 IRQ_TYPE_EDGE_RISING>, + <71 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "irq", "sleep", "wake"; + apple,no-liquid-detection; + }; +};