Skip to content

ComponentBase::addInterface() deprecation comment + assert message #19

Description

@jim-bcom

As I was removing warnings in our code base, I noticed one about ComponentBase::addInterface() being deprecated.
I had to look into the code to determine by what I could replace my call: addInterface() calls declareInterface().

  • Could you add a comment in the attribute (e.g. [[deprecated("Use declareInterface() instead")]]) ? The method could also be removed but maybe you prefer to wait for a new major release to break this API ?

  • Also, the assert messages in declareInterface() are not up-to-date:

"Type passed to addInterface is not an interface "
[...]
"Interface type passed to addInterface is not a derived class of IComponentIntrospect !!"

Either use the new declareInterface() name or both, until addInterace() is removed ?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions