From d9d7b2103957a1d4a8a1c5d7fef69fc6742fb5f3 Mon Sep 17 00:00:00 2001 From: Mohammed Ezzat Date: Fri, 11 Mar 2016 09:02:46 +0200 Subject: [PATCH] squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding --- .../java/com/google/zxing/common/BitArray.java | 2 +- .../pdf417/encoder/PDF417HighLevelEncoder.java | 2 +- .../zxing/qrcode/decoder/FormatInformation.java | 14 +++++++------- .../java/me/sudar/zxingorient/ZxingOrient.java | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/zxing-orient/src/main/java/com/google/zxing/common/BitArray.java b/zxing-orient/src/main/java/com/google/zxing/common/BitArray.java index 0af7dd7..08e97df 100644 --- a/zxing-orient/src/main/java/com/google/zxing/common/BitArray.java +++ b/zxing-orient/src/main/java/com/google/zxing/common/BitArray.java @@ -307,7 +307,7 @@ public int[] getBitArray() { public void reverse() { int[] newBits = new int[bits.length]; // reverse all int's first - int len = ((size-1) / 32); + int len = (size-1) / 32; int oldBitsLen = len + 1; for (int i = 0; i < oldBitsLen; i++) { long x = (long) bits[i]; diff --git a/zxing-orient/src/main/java/com/google/zxing/pdf417/encoder/PDF417HighLevelEncoder.java b/zxing-orient/src/main/java/com/google/zxing/pdf417/encoder/PDF417HighLevelEncoder.java index 28e6e94..009a6e4 100644 --- a/zxing-orient/src/main/java/com/google/zxing/pdf417/encoder/PDF417HighLevelEncoder.java +++ b/zxing-orient/src/main/java/com/google/zxing/pdf417/encoder/PDF417HighLevelEncoder.java @@ -399,7 +399,7 @@ private static void encodeBinary(byte[] bytes, if (count == 1 && startmode == TEXT_COMPACTION) { sb.append((char) SHIFT_TO_BYTE); } else { - boolean sixpack = ((count % 6) == 0); + boolean sixpack = (count % 6) == 0; if (sixpack) { sb.append((char)LATCH_TO_BYTE); } else { diff --git a/zxing-orient/src/main/java/com/google/zxing/qrcode/decoder/FormatInformation.java b/zxing-orient/src/main/java/com/google/zxing/qrcode/decoder/FormatInformation.java index 894e321..6731118 100644 --- a/zxing-orient/src/main/java/com/google/zxing/qrcode/decoder/FormatInformation.java +++ b/zxing-orient/src/main/java/com/google/zxing/qrcode/decoder/FormatInformation.java @@ -86,13 +86,13 @@ static int numBitsDiffering(int a, int b) { a ^= b; // a now has a 1 bit exactly where its bit differs with b's // Count bits set quickly with a series of lookups: return BITS_SET_IN_HALF_BYTE[a & 0x0F] + - BITS_SET_IN_HALF_BYTE[(a >>> 4 & 0x0F)] + - BITS_SET_IN_HALF_BYTE[(a >>> 8 & 0x0F)] + - BITS_SET_IN_HALF_BYTE[(a >>> 12 & 0x0F)] + - BITS_SET_IN_HALF_BYTE[(a >>> 16 & 0x0F)] + - BITS_SET_IN_HALF_BYTE[(a >>> 20 & 0x0F)] + - BITS_SET_IN_HALF_BYTE[(a >>> 24 & 0x0F)] + - BITS_SET_IN_HALF_BYTE[(a >>> 28 & 0x0F)]; + BITS_SET_IN_HALF_BYTE[a >>> 4 & 0x0F] + + BITS_SET_IN_HALF_BYTE[a >>> 8 & 0x0F] + + BITS_SET_IN_HALF_BYTE[a >>> 12 & 0x0F] + + BITS_SET_IN_HALF_BYTE[a >>> 16 & 0x0F] + + BITS_SET_IN_HALF_BYTE[a >>> 20 & 0x0F] + + BITS_SET_IN_HALF_BYTE[a >>> 24 & 0x0F] + + BITS_SET_IN_HALF_BYTE[a >>> 28 & 0x0F]; } /** diff --git a/zxing-orient/src/main/java/me/sudar/zxingorient/ZxingOrient.java b/zxing-orient/src/main/java/me/sudar/zxingorient/ZxingOrient.java index 91a1b85..aba0609 100644 --- a/zxing-orient/src/main/java/me/sudar/zxingorient/ZxingOrient.java +++ b/zxing-orient/src/main/java/me/sudar/zxingorient/ZxingOrient.java @@ -122,7 +122,7 @@ public final void initiateScan(Collection desiredBarcodeFormats, int cam // intentScan.putExtra((Intents.Scan.FLASH), flash); intentScan.putExtra(Intents.Scan.VIBRATE, vibrate); - intentScan.putExtra((Intents.Scan.BEEP), playBeep); + intentScan.putExtra(Intents.Scan.BEEP, playBeep); if(iconID != null) intentScan.putExtra(Intents.Scan.ICON_ID,iconID); if(toolbarColor != null) intentScan.putExtra(Intents.Scan.TOOLBAR_COLOR,toolbarColor);