|
| 1 | +# Codebase issue scan: proposed fix tasks |
| 2 | + |
| 3 | +## 1) Typo fix task |
| 4 | +- **Issue:** The HTTP user agent string uses `clawd-rust-tools/0.1`, which appears to be a spelling drift from the repository/product naming (`claw`). |
| 5 | +- **Impact:** Inconsistent telemetry/log tagging and harder grep/observability across services when searching for `claw` identifiers. |
| 6 | +- **Task proposal:** Rename the user-agent token to `claw-rust-tools/0.1` (or a centrally-defined crate/version-derived user-agent constant) and update any tests that assert the old literal. |
| 7 | +- **Acceptance criteria:** All references and tests use the corrected token; no behavior changes beyond identifier consistency. |
| 8 | + |
| 9 | +## 2) Bug fix task |
| 10 | +- **Issue:** `src.main` ignores `--no-plugin-commands` and `--no-skill-commands` when `commands --query ...` is used, because the query path calls `render_command_index(...)` directly without applying the include/exclude filters. |
| 11 | +- **Impact:** CLI behavior is inconsistent and user-provided filtering flags are silently ignored for query usage. |
| 12 | +- **Task proposal:** Refactor command index rendering so query and non-query paths share the same filtered command source (e.g., `get_commands(...)` first, then apply query search over that filtered set). |
| 13 | +- **Acceptance criteria:** `commands --query X --no-plugin-commands` and `commands --query X --no-skill-commands` produce outputs that respect each exclusion flag. |
| 14 | + |
| 15 | +## 3) Code comment/documentation discrepancy task |
| 16 | +- **Issue:** The lane completion module-level docs say completion is detected when "Code pushed (has output file)", but `detect_lane_completion(...)` does not inspect `output_file`; it only trusts the external boolean `has_pushed`. |
| 17 | +- **Impact:** The inline documentation overstates what this function validates itself, which can mislead future maintainers and reviewers. |
| 18 | +- **Task proposal:** Align docs/comments with implementation **or** update implementation to validate `output.output_file` semantics directly (and document exact source-of-truth for "pushed"). |
| 19 | +- **Acceptance criteria:** Comments/docs and runtime behavior agree on how push status is determined. |
| 20 | + |
| 21 | +## 4) Test improvement task |
| 22 | +- **Issue:** Snapshot-size tests in `tests/test_porting_workspace.py` use hard minimums (`>=150` commands, `>=100` tools, coverage thresholds), which are brittle for legitimate snapshot churn and can produce noisy failures. |
| 23 | +- **Impact:** Reduced test signal quality; harmless snapshot updates can fail CI even when behavior remains correct. |
| 24 | +- **Task proposal:** Replace absolute magic-number thresholds with invariant-based assertions (e.g., non-empty snapshots, monotonic schema checks, command/tool lookup sanity) plus a single snapshot-contract check tied to explicit version metadata. |
| 25 | +- **Acceptance criteria:** Tests fail only on semantic regressions, not ordinary curated snapshot updates. |
0 commit comments