fix: preserve spinner cursor recovery on write errors

Agent-Logs-Url: https://github.com/badMade/claw-code/sessions/56bca0b3-24cf-4c30-a1e4-19d7b17df2c5

Co-authored-by: badMade <106821302+badMade@users.noreply.github.com>

Author: Copilot

rust/crates/rusty-claude-cli/src/render.rs

@@ -99,16 +99,19 @@ impl Spinner {
         out: &mut impl Write,
     ) -> io::Result<()> {
         self.frame_index = 0;
-        self.cursor_hidden = false;
-        execute!(
+        let show_result = execute!(
             out,
             MoveToColumn(0),
             Clear(ClearType::CurrentLine),
             SetForegroundColor(theme.spinner_done),
             Print(format!("✔ {label}\n")),
             ResetColor,
             Show
-        )?;
+        );
+        if show_result.is_ok() {
+            self.cursor_hidden = false;
+        }
+        show_result?;
         out.flush()
     }
 
@@ -119,16 +122,19 @@ impl Spinner {
         out: &mut impl Write,
     ) -> io::Result<()> {
         self.frame_index = 0;
-        self.cursor_hidden = false;
-        execute!(
+        let show_result = execute!(
             out,
             MoveToColumn(0),
             Clear(ClearType::CurrentLine),
             SetForegroundColor(theme.spinner_failed),
             Print(format!("✘ {label}\n")),
             ResetColor,
             Show
-        )?;
+        );
+        if show_result.is_ok() {
+            self.cursor_hidden = false;
+        }
+        show_result?;
         out.flush()
     }
 }
@@ -927,6 +933,7 @@ fn strip_ansi(input: &str) -> String {
 #[cfg(test)]
 mod tests {
     use super::{strip_ansi, MarkdownStreamState, Spinner, TerminalRenderer};
+    use std::io::{self, Write};
 
     #[test]
     fn renders_markdown_with_styling_and_lists() {
@@ -1081,4 +1088,48 @@ mod tests {
         let output = String::from_utf8_lossy(&out);
         assert!(output.contains("Working"));
     }
+
+    struct AlwaysFailWriter;
+
+    impl Write for AlwaysFailWriter {
+        fn write(&mut self, _buf: &[u8]) -> io::Result<usize> {
+            Err(io::Error::other("write failed"))
+        }
+
+        fn flush(&mut self) -> io::Result<()> {
+            Ok(())
+        }
+    }
+
+    #[test]
+    fn spinner_finish_error_keeps_cursor_hidden_for_drop_recovery() {
+        let terminal_renderer = TerminalRenderer::new();
+        let mut spinner = Spinner::new();
+        let mut out = Vec::new();
+        spinner
+            .tick("Working", terminal_renderer.color_theme(), &mut out)
+            .expect("tick succeeds");
+
+        let mut failing_out = AlwaysFailWriter;
+        let result = spinner.finish("Done", terminal_renderer.color_theme(), &mut failing_out);
+
+        assert!(result.is_err());
+        assert!(spinner.cursor_hidden);
+    }
+
+    #[test]
+    fn spinner_fail_error_keeps_cursor_hidden_for_drop_recovery() {
+        let terminal_renderer = TerminalRenderer::new();
+        let mut spinner = Spinner::new();
+        let mut out = Vec::new();
+        spinner
+            .tick("Working", terminal_renderer.color_theme(), &mut out)
+            .expect("tick succeeds");
+
+        let mut failing_out = AlwaysFailWriter;
+        let result = spinner.fail("Done", terminal_renderer.color_theme(), &mut failing_out);
+
+        assert!(result.is_err());
+        assert!(spinner.cursor_hidden);
+    }
 }