From 3d00408b2bc59f06a526a5bb33b58fbd90554cea Mon Sep 17 00:00:00 2001 From: balayanv <94178612+balayanv@users.noreply.github.com> Date: Sun, 21 Apr 2024 03:19:59 +0400 Subject: [PATCH 1/2] Minor Update to java README.md i believe batching example intended to actually batch not send every transfer as a batch of 1 --- src/clients/java/README.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/clients/java/README.md b/src/clients/java/README.md index cc65b20e50..4b6a7f0dd8 100644 --- a/src/clients/java/README.md +++ b/src/clients/java/README.md @@ -317,17 +317,16 @@ var transferIds = new long[] {100, 101, 102}; var debitIds = new long[] {1, 2, 3}; var creditIds = new long[] {4, 5, 6}; var amounts = new long[] {1000, 29, 11}; +TransferBatch batch = new TransferBatch(3); for (int i = 0; i < transferIds.length; i++) { - TransferBatch batch = new TransferBatch(1); batch.add(); batch.setId(transferIds[i]); batch.setDebitAccountId(debitIds[i]); batch.setCreditAccountId(creditIds[i]); batch.setAmount(amounts[i]); - - CreateTransferResultBatch errors = client.createTransfers(batch); - // error handling omitted } +CreateTransferResultBatch errors = client.createTransfers(batch); +// error handling omitted ``` But the insert rate will be a *fraction* of From b340ae231ccc25154483db4d0690a8267affc7c8 Mon Sep 17 00:00:00 2001 From: balayanv <94178612+balayanv@users.noreply.github.com> Date: Sun, 21 Apr 2024 03:29:37 +0400 Subject: [PATCH 2/2] Update README.md --- src/clients/java/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/clients/java/README.md b/src/clients/java/README.md index 4b6a7f0dd8..ff36628ba2 100644 --- a/src/clients/java/README.md +++ b/src/clients/java/README.md @@ -317,7 +317,7 @@ var transferIds = new long[] {100, 101, 102}; var debitIds = new long[] {1, 2, 3}; var creditIds = new long[] {4, 5, 6}; var amounts = new long[] {1000, 29, 11}; -TransferBatch batch = new TransferBatch(3); +TransferBatch batch = new TransferBatch(transferIds.length); for (int i = 0; i < transferIds.length; i++) { batch.add(); batch.setId(transferIds[i]);