chore: misc qol improvements (#140)

Author: meyer9

.gitignore

@@ -19,3 +19,4 @@ coverage/
 node_modules
 yarn-debug.log*
 yarn-error.log*
+.env*.local

runner/benchmark/definition.go

@@ -6,6 +6,7 @@ import (
 	"os"
 	"os/exec"
 	"path"
+	"path/filepath"
 	"strings"
 
 	"github.com/base/base-bench/runner/payload"
@@ -63,7 +64,9 @@ func (s SnapshotDefinition) CreateSnapshot(nodeType string, outputDir string) er
 		return fmt.Errorf("failed to get absolute path of outputDir: %w", err)
 	}
 
-	outputDir = path.Join(currentDir, outputDir)
+	if !filepath.IsAbs(outputDir) {
+		outputDir = path.Join(currentDir, outputDir)
+	}
 
 	var cmdBin string
 	var args []string

runner/network/consensus/sequencer_consensus.go

@@ -26,6 +26,7 @@ import (
 	"github.com/ethereum/go-ethereum/log"
 	"github.com/ethereum/go-ethereum/rpc"
 	"github.com/pkg/errors"
+	"golang.org/x/sync/errgroup"
 )
 
 // SequencerConsensusClient is a fake consensus client that generates blocks on a timer.
@@ -208,28 +209,42 @@ func (f *SequencerConsensusClient) Propose(ctx context.Context, blockMetrics *me
 	sendCallsPerBatch := 100
 	batches := (len(sendTxs) + sendCallsPerBatch - 1) / sendCallsPerBatch
 
-	for i := 0; i < batches; i++ {
-		batch := sendTxs[i*sendCallsPerBatch : min((i+1)*sendCallsPerBatch, len(sendTxs))]
-		results := make([]interface{}, len(batch))
-
-		batchCall := make([]rpc.BatchElem, len(batch))
-		for j, tx := range batch {
-			batchCall[j] = rpc.BatchElem{
-				Method: "eth_sendRawTransaction",
-				Args:   []interface{}{hexutil.Encode(tx)},
-				Result: &results[j],
-			}
+	// Process batches in parallel, 4 at a time
+	parallelBatches := 4
+	for i := 0; i < batches; i += parallelBatches {
+		g, gCtx := errgroup.WithContext(ctx)
+
+		for j := 0; j < parallelBatches && i+j < batches; j++ {
+			batchIdx := i + j
+			g.Go(func() error {
+				batch := sendTxs[batchIdx*sendCallsPerBatch : min((batchIdx+1)*sendCallsPerBatch, len(sendTxs))]
+				results := make([]interface{}, len(batch))
+
+				batchCall := make([]rpc.BatchElem, len(batch))
+				for k, tx := range batch {
+					batchCall[k] = rpc.BatchElem{
+						Method: "eth_sendRawTransaction",
+						Args:   []interface{}{hexutil.Encode(tx)},
+						Result: &results[k],
+					}
+				}
+
+				err := f.client.Client().BatchCallContext(gCtx, batchCall)
+				if err != nil {
+					return errors.Wrap(err, "failed to send transactions")
+				}
+
+				for _, tx := range batchCall {
+					if tx.Error != nil {
+						return errors.Wrapf(tx.Error, "failed to send transaction %#v", tx.Args[0])
+					}
+				}
+				return nil
+			})
 		}
 
-		err := f.client.Client().BatchCallContext(ctx, batchCall)
-		if err != nil {
-			return nil, errors.Wrap(err, "failed to send transactions")
-		}
-
-		for _, tx := range batchCall {
-			if tx.Error != nil {
-				return nil, errors.Wrapf(tx.Error, "failed to send transaction %#v", tx.Args[0])
-			}
+		if err := g.Wait(); err != nil {
+			return nil, err
 		}
 	}
 

runner/network/consensus/validator_consensus.go

@@ -33,7 +33,7 @@ func (f *SyncingConsensusClient) propose(ctx context.Context, payload *engine.Ex
 
 	root := crypto.Keccak256Hash([]byte("fake-beacon-block-root"), big.NewInt(1).Bytes())
 
-	f.log.Info("Validate payload", "payload_index", payload.Number)
+	f.log.Info("Validate payload", "payload_index", payload.Number, "num_txs", len(payload.Transactions))
 	startTime := time.Now()
 	err := f.newPayload(ctx, payload, root)
 	if err != nil {