Skip to content

Commit f81ac1d

Browse files
committed
get rid of @ts-expect-error
1 parent 4f73390 commit f81ac1d

2 files changed

Lines changed: 7 additions & 16 deletions

File tree

src/modules/connectors.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { AxiosInstance } from "axios";
22
import {
33
ConnectorIntegrationType,
44
ConnectorAccessTokenResponse,
5-
ConnectorInitiateResponse,
65
ConnectorConnectionResponse,
76
ConnectorsModule,
87
UserConnectorsModule,
@@ -74,33 +73,32 @@ export function createUserConnectorsModule(
7473
appId: string
7574
): UserConnectorsModule {
7675
return {
77-
// @ts-expect-error Return type mismatch - implementation returns object, interface expects string
7876
async getAppUserAccessToken(
7977
connectorId: string
80-
): Promise<ConnectorAccessTokenResponse> {
78+
): Promise<string> {
8179
if (!connectorId || typeof connectorId !== "string") {
8280
throw new Error("Connector ID is required and must be a string");
8381
}
8482

85-
const response = await axios.get<ConnectorAccessTokenResponse>(
83+
const response = await axios.get(
8684
`/apps/${appId}/app-user-auth/connectors/${connectorId}/token`
8785
);
8886

89-
// @ts-expect-error
90-
return response.access_token;
87+
const data = response as unknown as { access_token: string };
88+
return data.access_token;
9189
},
9290

9391
async connectAppUser(connectorId: string): Promise<string> {
9492
if (!connectorId || typeof connectorId !== "string") {
9593
throw new Error("Connector ID is required and must be a string");
9694
}
9795

98-
const response = await axios.post<ConnectorInitiateResponse>(
96+
const response = await axios.post(
9997
`/apps/${appId}/app-user-auth/connectors/${connectorId}/initiate`
10098
);
10199

102-
// @ts-expect-error
103-
return response.redirect_url;
100+
const data = response as unknown as { redirect_url: string };
101+
return data.redirect_url;
104102
},
105103

106104
async disconnectAppUser(connectorId: string): Promise<void> {

src/modules/connectors.types.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,6 @@ export interface ConnectorConnectionResponse {
3838
connectionConfig: Record<string, string> | null;
3939
}
4040

41-
/**
42-
* Response from the connectors initiate endpoint.
43-
*/
44-
export interface ConnectorInitiateResponse {
45-
redirect_url: string;
46-
}
47-
4841
/**
4942
* Connectors module for managing app-scoped OAuth tokens for external services.
5043
*

0 commit comments

Comments
 (0)