sp_list definition missing in the vignette?

[jlprol]

In the first code section of the {did} vignette (https://bcallaway11.github.io/did/articles/did-basics.html) the definition of the sp object is missing, isn't it?

There is only sp$te.e <- 1:time.periods but the other simulation parameters are missing.

[0trm]

It was defined in a hidden chunk (echo=FALSE) at the time. Commit d3d4c54 moved it into the visible chunk, so the vignette now shows the full setup:

library(did)
set.seed(1814)
sp <- reset.sim()             # default simulation parameters, exported by did
sp$te <- 0
time.periods <- 4
sp$te.e <- 1:time.periods     # dynamic effects
dta <- build_sim_dataset(sp)

reset.sim() returns the list that build_sim_dataset() reads as sp_list (time.periods, te, te.e, n and so on); see ?reset.sim. Checked on did 2.5.1.