From 57d73ce49442d903021f11b6906737390b5a1e1f Mon Sep 17 00:00:00 2001
From: dkeven <dkvvven@gmail.com>
Date: Thu, 27 Nov 2025 17:09:25 +0800
Subject: [PATCH] feat: GC GPU bindings of uninstalled App

---
 pkg/scheduler/scheduler.go | 46 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/pkg/scheduler/scheduler.go b/pkg/scheduler/scheduler.go
index 2392e64af..60237df69 100644
--- a/pkg/scheduler/scheduler.go
+++ b/pkg/scheduler/scheduler.go
@@ -298,6 +298,46 @@ func (s *Scheduler) CleanupGPUBindingsLoop() {
 				}
 				toDelete := make([]string, 0)
 
+				existingApps := make(map[string]struct{})
+				appDiscoveryOK := true
+				if deps, err := s.kubeClient.AppsV1().Deployments(metav1.NamespaceAll).List(context.Background(),
+					metav1.ListOptions{LabelSelector: util.AppNameLabelKey}); err != nil {
+					klog.ErrorS(err, "CleanupGPUBindingsLoop: failed to list Deployments for existing apps")
+					appDiscoveryOK = false
+				} else {
+					for i := range deps.Items {
+						if app := deps.Items[i].Labels[util.AppNameLabelKey]; app != "" {
+							existingApps[app] = struct{}{}
+						}
+					}
+				}
+				if appDiscoveryOK {
+					if ssets, err := s.kubeClient.AppsV1().StatefulSets(metav1.NamespaceAll).List(context.Background(),
+						metav1.ListOptions{LabelSelector: util.AppNameLabelKey}); err != nil {
+						klog.ErrorS(err, "CleanupGPUBindingsLoop: failed to list StatefulSets for existing apps")
+						appDiscoveryOK = false
+					} else {
+						for i := range ssets.Items {
+							if app := ssets.Items[i].Labels[util.AppNameLabelKey]; app != "" {
+								existingApps[app] = struct{}{}
+							}
+						}
+					}
+				}
+				if appDiscoveryOK {
+					if pods, err := s.kubeClient.CoreV1().Pods(metav1.NamespaceAll).List(context.Background(),
+						metav1.ListOptions{LabelSelector: util.AppNameLabelKey}); err != nil {
+						klog.ErrorS(err, "CleanupGPUBindingsLoop: failed to list Pods for existing apps")
+						appDiscoveryOK = false
+					} else {
+						for i := range pods.Items {
+							if app := pods.Items[i].Labels[util.AppNameLabelKey]; app != "" {
+								existingApps[app] = struct{}{}
+							}
+						}
+					}
+				}
+
 				type key struct {
 					app  string
 					uuid string
@@ -308,6 +348,12 @@ func (s *Scheduler) CleanupGPUBindingsLoop() {
 						toDelete = append(toDelete, b.Name)
 						continue
 					}
+					if appDiscoveryOK {
+						if _, ok := existingApps[b.Spec.AppName]; !ok {
+							toDelete = append(toDelete, b.Name)
+							continue
+						}
+					}
 					k := key{app: b.Spec.AppName, uuid: b.Spec.UUID}
 					group[k] = append(group[k], b)
 				}