Skip to content

Commit d7cb764

Browse files
authored
Merge pull request #59 from beclab/feat/reconstruct-train-rank
fix: fix findBySourceAndRankTime method wrong for rank
2 parents 3925247 + 4aec13d commit d7cb764

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

train-rank/src/knowledgebase_api.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2345,7 +2345,7 @@ namespace knowledgebase
23452345
{
23462346
http_client *current_client = HttpClientSingleton::get_instance();
23472347
http_client &client = *current_client;
2348-
std::string current_suffix = std::string(RECOMMEND_TRACE_INFO_API_SUFFIX) + "/findBySourceAndRankTime?source=" + source + "&rank_time" + std::to_string(rank_time);
2348+
std::string current_suffix = std::string(RECOMMEND_TRACE_INFO_API_SUFFIX) + "/findBySourceAndRankTime?source=" + source + "&rank_time=" + std::to_string(rank_time);
23492349
LOG(DEBUG) << "current_suffix " << current_suffix << std::endl;
23502350

23512351
std::optional<RecommendTraceInfo> option_info = std::nullopt;

train-rank/test/knowledge_api_test.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -603,8 +603,8 @@ TEST(KnowledgeApiTest, findRecommendTraceInfoByRankTimeAndSource)
603603
// --gtest_filter=KnowledgeApiTest.findRecommendTraceInfoByRankTimeAndSource
604604
initDevelop();
605605
init_log();
606-
std::string source = "testsource";
607-
int64_t rank_time = 1711080226;
606+
std::string source = "r4wechat";
607+
int64_t rank_time = 1735832592;
608608
std::optional<RecommendTraceInfo> recommend_trace_info = knowledgebase::findRecommendTraceInfoByRankTimeAndSource(source, rank_time);
609609
if (recommend_trace_info != std::nullopt)
610610
{
@@ -618,11 +618,11 @@ TEST(KnowledgeApiTest, findAllRecomendTraceInfoRankTimesBySource)
618618
// --gtest_filter=KnowledgeApiTest.findAllRecomendTraceInfoRankTimesBySource
619619
initDevelop();
620620
init_log();
621-
std::string source = "testsource";
621+
std::string source = "r4techbiz";
622622
std::vector<int> rank_times = knowledgebase::findAllRecomendTraceInfoRankTimesBySource(source);
623623
for (auto current : rank_times)
624624
{
625-
std::cout << current << " ";
625+
std::cout << current << " " << std::endl;
626626
}
627627
std::cout << std::endl;
628628
}

0 commit comments

Comments
 (0)