Updating range with same values executes query

[vatsake]

Describe the bug
When updating a model, Laravel first checks if the updated value differs from model's.
If it does, then it will execute a update query. If it doesn't, then a update query won't be executed.

To Reproduce
Steps to reproduce the behavior:

$dateRange = new TimestampRange(
    Carbon::now()->startOfDay();
    Carbon::now()->endOfDay();
);
$model = Model::create([
   'timestampRange' => $dateRange
]);
$model->update([
   'timestampRange' => $dateRange
]);
dd($model->getChanges()); // <-- This should be empty, but it's not.

Maybe something related with this:
dd($model->timestampRange->forSql(), $dateRange->forSql());

[belamov]

are you sure it is a problem in this package?

[belamov]

i wrote this test

    /** @test */
    public function model_get_changes(): void
    {
        $from = CarbonImmutable::parse('2010-01-10');
        $to = CarbonImmutable::parse('2010-01-15');
        $dateRange = new DateRange($from->toDateString(), $to->toDateString(), '[', ')');
        $model = $this->createModel(
            [
                'date_range' => $dateRange,
            ]
        );

        $model->update(
            [
                'date_range' => $dateRange,
            ]
        );

        $this->assertEmpty($model->getChanges());

    }

    /**
     * @param  array  $attributes
     * @return Range
     */
    protected function createModel(array $attributes = []): Range
    {
        return Range::create($attributes);
    }

and it passes, i dont see any problem

please submit your expectations and reality as failed test that shoudl be green, so i can look into it

[belamov]

and it works as expected with timestamp range as in your example

    /** @test */
    public function model_get_changes(): void
    {
        $timestampRange = new TimestampRange(
            Carbon::now()->startOfDay(),
            Carbon::now()->endOfDay(),
        );
        $model = $this->createModel(
            [
                'timestamp_range' => $timestampRange,
            ]
        );

        $model->update(
            [
                'timestamp_range' => $timestampRange,
            ]
        );

        $this->assertEmpty($model->getChanges());
    }

     /**
     * @param  array  $attributes
     * @return Range
     */
    protected function createModel(array $attributes = []): Range
    {
        return Range::create($attributes);
    }

this test is also green

[vatsake]

@belamov
Can you try it like this?

$model = Model::first(); // Get it from database
$dateRange = new TimestampRange( // <-- Range, which is same as in the database
    Carbon::now()->startOfDay();
    Carbon::now()->endOfDay();
);
$model->update(['timestampRange' => $dateRange]);
dd($model->getChanges());

[vatsake]

@belamov
In Laravel trait HasAttributes method getDirty() gets the attributes that have been changed.
It uses originalIsEquivalent($key).

For testing purposes I added this:

This outputs (One of the values has quotes):

[belamov]

@vatsake i wrote test like this:

    /** @test */
    public function it_casts_date_range_column(): void
    {
        $from = CarbonImmutable::parse('2010-01-10');
        $to = CarbonImmutable::parse('2010-01-15');
        $dateRange = new DateRange($from->toDateString(), $to->toDateString(), '[', ')');
        $model = $this->createModel(
            [
                'date_range' => $dateRange,
            ]
        );

        $model = $model->fresh();

        $this->assertDatabaseHas('ranges', ['id' => $model->id]);
        $this->assertInstanceOf(DateRange::class, $model->date_range);
        $this->assertEquals('[', $model->date_range->fromBound());
        $this->assertEquals(')', $model->date_range->toBound());
        $this->assertEquals($from, $model->date_range->from());
        $this->assertEquals($to, $model->date_range->to());

        $model->date_range = new DateRange($from->toDateString(), $to->toDateString(), '[', ')');
        $this->assertEmpty($model->getChanges());
    }

    /**
     * @param  array  $attributes
     * @return Range
     */
    protected function createModel(array $attributes = []): Range
    {
        return Range::create($attributes);
    }

and it is passing, so i don't know how to help you at this point

next time please provide a pr with failing test and why you think it should be passing, so we can have more constructive discussion

[vatsake]

#31 Not sure if you like the solution.

[belamov]

thanks a lot for your contributions, seems legit