Added resetAutoReleaseOnDetection property to sensors#169
Open
Kellojo wants to merge 3 commits into
Open
Conversation
benzman81
requested changes
Oct 5, 2022
benzman81
left a comment
benzman81
left a comment
Owner
There was a problem hiding this comment.
Please correct the commented lines.
| } | ||
|
|
||
| HttpWebHookSensorAccessory.prototype.setAutoReleaseTimeout = function () { | ||
| if (!this.autoRelease || !this.resetAutoReleaseOnDetection) return; |
Owner
There was a problem hiding this comment.
This prevents autoreleases if not resetAutoReleaseOnDetection is set. The flag resetAutoReleaseOnDetection should be handled as optional.
|
|
||
| HttpWebHookSensorAccessory.prototype.setAutoReleaseTimeout = function () { | ||
| if (!this.autoRelease || !this.resetAutoReleaseOnDetection) return; | ||
| clearTimeout(this[this.getTimeoutKey()]); |
Owner
There was a problem hiding this comment.
Clearing and resetting timeout should only be done if resetAutoReleaseOnDetection is true. Otherwise it should always add the timeout as before, so nothing break.
| HttpWebHookSensorAccessory.prototype.setAutoReleaseTimeout = function () { | ||
| if (!this.autoRelease || !this.resetAutoReleaseOnDetection) return; | ||
| clearTimeout(this[this.getTimeoutKey()]); | ||
| this[this.getTimeoutKey()] = setTimeout(this.resetToInitialState.bind(this), this.autoReleaseTime); |
Owner
|
@Kellojo in case you did not see it, I requested some changes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving #168