Bug: Cloudflare: Subscription for load balancing not found

[bernardhalas]

Opening on behalf of @eminden

Current Behaviour

Claudie v0.9.16, with a single LB, without any cloudflare subscription ends up firing subscription for Load Balancing not found.

As @eminden says:

Without this change it was basically not running through the updates.

A custom patch works around this situation, but it would be good to have a proper fix:

diff --git a/proto/pb/spec/utils.go b/proto/pb/spec/utils.go
index 0295b81a..973d229b 100644
--- a/proto/pb/spec/utils.go
+++ b/proto/pb/spec/utils.go
@@ -280,7 +280,7 @@ func (x *CloudflareProvider) GetSubscription() (bool, error) {
                        return true, nil
                }
        }
-       return false, fmt.Errorf("subscription for Load Balancing not found")
+       return false, nil
 }

Expected Behaviour

No error is raised from Claudie.

Steps To Reproduce

1. Apply the manifest from the attachment on v0.9.15
2. Upgrade to v0.9.16

IM attached.

im.yml.txt