chore: ETXTBSY log to WARN + version-agnostic smoke docs (item 46)#318
Merged
Conversation
On service start the supervisor refreshes the dataRoot operation-server helper by
copying the current launcher binary over it. In service mode that helper IS the
running binary, so the copy fails with ETXTBSY ("text file busy") — a benign,
expected condition (the running copy is already current; the next start refreshes
it while it is free). It now logs at WARN via a small pure classifier
(refresh_error_is_benign_busy, unit-tested); genuine failures still log ERROR.
Adds a WARN level to common::log.
Strip the per-release "version under test" stamps from the three smoke docs so they no longer need editing every release; the smoke target now lives in a single top-of-doc tag. Rename to stable generic names (smoke-checklist/full/runbook.md), add Module 14 (Linux App-section UX), correct the semanage fcontext -l checks to use sudo, and keep the version-specific bits that matter (the beta.40 "update from" build and historical fix provenance).
bilbospocketses
added
the
release:none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bits of owed polish (item 46), no release impact on its own.
G2 — quieter Linux service start
On service start the launcher refreshes its bundled operation-server helper by copying the current binary over it. In service mode that helper is the running binary, so the copy fails with
ETXTBSY("text file busy") and logged a scaryERROR. It's harmless — the running copy is already current, and the next start refreshes it while it's free — so it now logs at WARN. A small pure classifier (refresh_error_is_benign_busy, unit-tested) keeps genuine refresh failures at ERROR. Adds a WARN level to the shared logger.Smoke docs — version-agnostic
The smoke docs stamped the build-under-test version into nearly every row, so they needed a sweep every release. Stripped those stamps; the smoke target now lives in one top-of-doc tag you bump once per release. Also:
smoke-checklist.md/smoke-full.md/smoke-runbook.md.semanage fcontext -lverification commands to usesudo(they error as non-root).Verified locally: launcher + common unit tests pass, clippy
-D warningsclean.release:none— docs plus a cosmetic log change; ships with the next beta.