bisq's bitcoinj status

[oscarguindzberg]

In progress

• Merge to bisq project PR for using the latest bitcoinj 0.14.7 version with improvements on connection handling based on audit (useless if we migrate to bitcoinj 0.15)
  • Audit: Bisq's bitcoinj connection handling changes audit #30 (completed)
  • Fixes: Connection handling fixes #31 (completed)
  • PR to use that in bisq Use bitcoinj with connection handling audit fixes + Transaction.unCache() set confidence to null bisq#2618 (merging pending)
• Migration to bitcoinj 0.15
  • Oscar reviewed bitcoinj 0.15 release release notes https://bitcoinj.github.io/release-notes and everything looks ok.
  • Rebase bisq’s bitcoinj from bitcoinj 0.15.1 (completed)
    • https://github.com/bisq-network/bitcoinj/commits/bisq_0.15.1 (completed).
    • All commits added by me have a description linking to the commit on the 0.14.7 branch that
      originated it.
    • Many commits were combined.
    • Many commits were already included on upstream bitcoinj 0.15.1
  • Use bisq's bitcoinj 0.15 in bisq (merging pending)
    • [WIP] Use bisq's bitcoinj 0.15.1 bisq#2772
• Deprecated transaction confidence / broadcasting problem research
  • bisq bug: Problem broadcasting DAO proposal tx bisq#2639
  • bitcoinj upstream issue: TransactionConfidence caching problem in Transaction bitcoinj/bitcoinj#1769 (waiting for Andreas Schildbach feedback)
  • Tests to prove the problem on bitcoinj upstream: https://github.com/oscarguindzberg/bitcoinj/commits/tx-confidence-cache
  • Found out setting confidence to null in Transaction.unCache() is the best short term solution for bisq’s bitcoinj (upstream bitcoinj probably needs a more comprehensive solution). bisq’s bitcoinj 0.14.7 and 0.15.1 are already updated to include that fix
  • PR for Bisq to use the latest version of bitcoinj 0.14.7 and 0.15.1 (merging pending)
    • [WIP] Use bisq's bitcoinj 0.15.1 bisq#2772 now uses bitcoinj 0.15.1 that includes the fix
    • Use bitcoinj with connection handling audit fixes + Transaction.unCache() set confidence to null bisq#2618 now uses bitcoinj 0.14.7 that includes the fix
• PeerGroup.handlePeerDeath() + BlockingClient.socket.close() called twice
  • Upstream bug PeerGroup.handlePeerDeath() + BlockingClient.socket.close() called twice bitcoinj/bitcoinj#1765
  • Someone has to look at the bug again and confirm whether the bug described matches reality and then implement a solution.
  • I guess this is not causing big problems for Bisq.
  • The analysis is based on bitcoinj 0.14 but I guess it is still valid for bitcoinj 0.15.
• "Restore from seed" on "wallet template" upstream bitcoinj project is broken.
  • Upstream bug: Wallet template restore from seed fails bitcoinj/bitcoinj#1704
  • Waiting for someone to fix the bug.
  • It is important for Bisq that "restore from seed" works on "wallet template" because it is a benchmark on how bisq "restore from seed" should work.
• Path issue with serialized wallets migrated from pre-0.15 to 0.15
  • Upstream bug Path issue with serialized wallets migrated from pre-0.15 to 0.15 bitcoinj/bitcoinj#1812
  • A workaround was implemented on bisq by using BisqKeyChainFactory and isqKeyChainGroupStructure, but a generic upstream solution would be better.

TODO (i.e. not started yet)

• Review bisq usage of bitcoinj
• Segwit support
  • Support sending/receiving tp/from "bc1" addresses once bitcoinj 0.15 usage is merged.
• Improve multi-wallet support in bitcoinj
  • Spin off from Clone transaction before adding to wallet #18
  • See bitcoinj mailing list - Design doc: separating confidence out from transaction objects https://groups.google.com/forum/#!topic/bitcoinj/KsEWEnSdbN0
  • See Rethink WalletEventListener.onTransactionConfidenceChanged bitcoinj/bitcoinj#877
  • See WIP: Get rid of depth in TransactionConfidence. bitcoinj/bitcoinj#1553
• Run tor over nio in bitcoinj
  • Florian should know a lot about this.
• Implement tor / onion address support in bitcoinj upstream.
• Improve re-broadcasting of bitcoinj txs
  • Rebroadcasting occurs just at app restart, there should be some rebroadcasting while the app is running. E.g. when peers have no broadcasted it back after 45 seconds and/or when tx is not mined after 1 hour.
  • See bitcoinj mailing list https://groups.google.com/forum/#!topic/bitcoinj/lkK9N3NhoPY
  • See “reject” msg removal in bitcoin core mailing list https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016701.html
• Fix BitcoinJ bloom filters broken privacy
  • https://groups.google.com/forum/#!topic/bitcoinj/vodUFpdmskg
  • Feasibility for replacing Bitcoinj with Bitcoin Core SPV bisq#1062
  • https://www.coindesk.com/spv-support-billion-bitcoin-users-sizing-scaling-claim
  • Compact Client Side Filtering for Light Clients (Neutrino server-side support) bitcoin/bitcoin#11863