Commit e283ea4
ci: add the missing lint gate, and put typecheck in verify
Same two gaps as ai-forms (fixed there in #11), from the same scaffold:
- No lint at all. ESLint was not a dependency, there was no config, and no
script referenced it — so the fleet verify floor (lint AND typecheck AND
test) was unmet.
- `typecheck` existed but was not in `verify`. `build` is `tsc -p`, so types
were checked only as a side effect of emitting. That conflates "compiles
to dist" with "types are sound", and it evaporates the moment the build
strategy changes.
verify = lint → typecheck → build → test.
Recommended presets only. This is ~600 lines of library code; a bespoke rule
set would be a second opinion to maintain for no benefit. The floor is "lint
runs and can fail", not "lint encodes taste". Lint is clean on arrival, so this
closes a hole rather than deferring a backlog.
CI needs no change — ci.yml already calls `npm run verify` verbatim.
Verified: `npm run verify` passes — eslint clean, tsc clean, build clean,
31/31 tests.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent a60cee8 commit e283ea4
3 files changed
Lines changed: 1514 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
0 commit comments