fix: resolve test infrastructure issues

- Add next/server mock for Jest to handle NextRequest/NextResponse imports
- Fix api-responses tests to match actual function signatures:
  - jsonSuccess wraps data in response.data property
  - jsonValidationError expects ValidationError[] not object
  - formatZodErrors returns array not object with field properties

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: catomean

.eslintcache

@@ -0,0 +1,122 @@
+/**
+ * Mock for next/server in Jest tests
+ *
+ * This allows tests to import modules that use NextResponse/NextRequest
+ * without loading the actual Next.js server runtime.
+ */
+
+// Use global Request/Response if available (jsdom), otherwise create simple mocks
+const BaseRequest =
+  globalThis.Request ||
+  class MockRequest {
+    url: string;
+    method: string;
+    headers: Map<string, string>;
+    body: unknown;
+
+    constructor(input: string | URL, init?: RequestInit) {
+      this.url = input.toString();
+      this.method = init?.method || 'GET';
+      this.headers = new Map(Object.entries(init?.headers || {}));
+      this.body = init?.body;
+    }
+
+    json() {
+      return Promise.resolve(typeof this.body === 'string' ? JSON.parse(this.body) : this.body);
+    }
+  };
+
+const BaseResponse =
+  globalThis.Response ||
+  class MockResponse {
+    body: string | null;
+    status: number;
+    headers: Map<string, string>;
+
+    constructor(body?: string | null, init?: ResponseInit) {
+      this.body = body || null;
+      this.status = init?.status || 200;
+      this.headers = new Map(Object.entries(init?.headers || {}));
+    }
+
+    json() {
+      return Promise.resolve(this.body ? JSON.parse(this.body) : null);
+    }
+  };
+
+export class NextRequest extends BaseRequest {
+  nextUrl: URL;
+
+  constructor(input: string | URL, init?: RequestInit) {
+    super(input, init);
+    this.nextUrl = new URL(typeof input === 'string' ? input : input.toString());
+  }
+
+  get cookies() {
+    return {
+      get: jest.fn(),
+      getAll: jest.fn(() => []),
+      set: jest.fn(),
+      delete: jest.fn(),
+      has: jest.fn(() => false),
+    };
+  }
+
+  get geo() {
+    return {};
+  }
+
+  get ip() {
+    return '127.0.0.1';
+  }
+}
+
+export class NextResponse extends BaseResponse {
+  static json(body: unknown, init?: ResponseInit) {
+    const response = new NextResponse(JSON.stringify(body), {
+      ...init,
+      headers: {
+        ...init?.headers,
+        'content-type': 'application/json',
+      },
+    });
+    return response;
+  }
+
+  static redirect(url: string | URL, status?: number) {
+    return new NextResponse(null, {
+      status: status || 307,
+      headers: { Location: url.toString() },
+    });
+  }
+
+  static rewrite(destination: string | URL) {
+    return new NextResponse(null, {
+      headers: { 'x-middleware-rewrite': destination.toString() },
+    });
+  }
+
+  static next() {
+    return new NextResponse(null);
+  }
+
+  get cookies() {
+    return {
+      get: jest.fn(),
+      getAll: jest.fn(() => []),
+      set: jest.fn(),
+      delete: jest.fn(),
+    };
+  }
+}
+
+export const userAgent = jest.fn(() => ({
+  isBot: false,
+  browser: { name: 'Chrome', version: '100' },
+  device: { type: undefined, vendor: undefined, model: undefined },
+  engine: { name: 'Blink', version: '100' },
+  os: { name: 'Mac OS', version: '12' },
+  cpu: { architecture: undefined },
+}));
+
+export const userAgentFromString = jest.fn(() => userAgent());

__mocks__/next/server.ts

@@ -11,6 +11,7 @@ const customJestConfig = {
   testEnvironment: 'jest-environment-jsdom',
   moduleNameMapper: {
     '^@/(.*)$': '<rootDir>/$1',
+    '^next/server$': '<rootDir>/__mocks__/next/server.ts',
   },
   testMatch: [
     '<rootDir>/tests/**/*.test.ts',

jest.config.js

@@ -28,20 +28,20 @@ describe('API Response Helpers', () => {
   describe('jsonSuccess', () => {
     it('returns success response with data', async () => {
       const response = jsonSuccess({ user: 'test' });
-      const data = await response.json();
+      const result = await response.json();
 
       expect(response.status).toBe(200);
-      expect(data.success).toBe(true);
-      expect(data.user).toBe('test');
+      expect(result.success).toBe(true);
+      expect(result.data.user).toBe('test');
     });
 
     it('returns success response with message', async () => {
       const response = jsonSuccess({ id: 1 }, 'Created successfully');
-      const data = await response.json();
+      const result = await response.json();
 
-      expect(data.success).toBe(true);
-      expect(data.message).toBe('Created successfully');
-      expect(data.id).toBe(1);
+      expect(result.success).toBe(true);
+      expect(result.message).toBe('Created successfully');
+      expect(result.data.id).toBe(1);
     });
 
     it('returns success response with custom status', async () => {
@@ -101,14 +101,15 @@ describe('API Response Helpers', () => {
 
   describe('jsonValidationError', () => {
     it('returns 400 validation error response', async () => {
-      const response = jsonValidationError('Invalid input', { field: 'email' });
+      const details = [{ field: 'email', message: 'Invalid email format' }];
+      const response = jsonValidationError('Invalid input', details);
       const data = await response.json();
 
       expect(response.status).toBe(400);
       expect(data.success).toBe(false);
       expect(data.error).toBe('Invalid input');
       expect(data.code).toBe('VALIDATION_ERROR');
-      expect(data.details).toEqual({ field: 'email' });
+      expect(data.details).toEqual(details);
     });
   });
 
@@ -127,8 +128,10 @@ describe('API Response Helpers', () => {
       if (!result.success) {
         const formatted = formatZodErrors(result.error);
 
-        expect(formatted).toHaveProperty('email');
-        expect(formatted).toHaveProperty('password');
+        // formatZodErrors returns an array of { field, message } objects
+        expect(Array.isArray(formatted)).toBe(true);
+        expect(formatted.some((e) => e.field === 'email')).toBe(true);
+        expect(formatted.some((e) => e.field === 'password')).toBe(true);
       }
     });
 
@@ -145,7 +148,8 @@ describe('API Response Helpers', () => {
 
       if (!result.success) {
         const formatted = formatZodErrors(result.error);
-        expect(formatted).toBeDefined();
+        expect(Array.isArray(formatted)).toBe(true);
+        expect(formatted.some((e) => e.field === 'user.email')).toBe(true);
       }
     });
   });