From 387e92c74007538ae3dcc893c5e9de08470ce752 Mon Sep 17 00:00:00 2001
From: Mao Nakamoto <41178744+maonakamoto@users.noreply.github.com>
Date: Mon, 31 Aug 2026 14:29:54 +0200
Subject: [PATCH] fix(nav): the sidebar highlighted the current page and never
 announced it
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Both the desktop sidebar loop and the mobile bottom tab bar called isActive()
to paint nav-link-active / mobile-tab-item-active, and the desktop Settings
link compared pathname directly — none of the three set aria-current, so the
current page existed only for people who can see it. Zero occurrences of
aria-current anywhere in the repo.

.nav-link also came out near 41px (10px vertical padding around 14px text),
just under the 44px touch floor this repo already states explicitly on
.browse-chip. Says the floor now instead of leaving it to arithmetic.
.mobile-tab-item was already comfortably above it.

No visual change beyond the min-height.

Found by the fleet nav-contract audit, which flags a repo whose navigation
computes an active state and never announces it anywhere.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XeELB8b3N4JrT2asYL9WvE
---
 app/globals.css                  | 4 ++++
 components/portal/SidebarNav.tsx | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/app/globals.css b/app/globals.css
index 5c209f5..e341ef7 100644
--- a/app/globals.css
+++ b/app/globals.css
@@ -925,6 +925,10 @@ body {
   display: flex;
   align-items: center;
   gap: 12px;
+  /* 10px vertical padding around 14px text landed near 41px — just under the
+     44px touch floor. min-height says the floor explicitly rather than
+     leaving it to arithmetic that happens to work today. */
+  min-height: 44px;
   padding: 10px 12px;
   border-radius: 12px;
   font-size: 14px;
diff --git a/components/portal/SidebarNav.tsx b/components/portal/SidebarNav.tsx
index be9c3d1..d37246b 100644
--- a/components/portal/SidebarNav.tsx
+++ b/components/portal/SidebarNav.tsx
@@ -142,6 +142,7 @@ export default function SidebarNav({ userName, userEmail, userRole, hasSeller, l
             <Link
               key={href}
               href={href}
+              aria-current={isActive(pathname, href, match) ? "page" : undefined}
               className={`nav-link ${isActive(pathname, href, match) ? "nav-link-active" : "nav-link-inactive"}`}
             >
               <Icon className="w-4 h-4 flex-shrink-0" />
@@ -155,6 +156,7 @@ export default function SidebarNav({ userName, userEmail, userRole, hasSeller, l
           <LocaleSwitcher current={locale} />
           <Link
             href={PORTAL_ROUTES.settings}
+            aria-current={pathname === PORTAL_ROUTES.settings ? "page" : undefined}
             className={`nav-link ${pathname === PORTAL_ROUTES.settings ? "nav-link-active" : "nav-link-inactive"}`}
           >
             <Settings className="w-4 h-4 flex-shrink-0" />
@@ -211,6 +213,7 @@ export default function SidebarNav({ userName, userEmail, userRole, hasSeller, l
             <Link
               key={href}
               href={href}
+              aria-current={isActive(pathname, href, match) ? "page" : undefined}
               className={`mobile-tab-item ${isActive(pathname, href, match) ? "mobile-tab-item-active" : "mobile-tab-item-inactive"}`}
             >
               <Icon