Feedback 1

[wilhelmloof]

Great that you are tackling the lack of AntiContainer functionality for modern browsers.

Is myAntiContainer fully compatible with AntiContainer patterns (except sandbox)? Can I add all my old patterns to your version (preferably in bulk by copying/moving them)? "Load Rules" didn't do anything. And a bit confusing with both "Update Rule" and "Save These Rules", my interpretation is that update rule is for the active rule and save these is if you have loaded rules.

I had difficulties writing custom patterns and also using the existing ones didn't download desired data.
I tried photobucket.com and gfycat.com, the pattern for those sites didn't download the desired images. Creating custom rules did not seem to work, neither simple Redirectors or Page Examiner rules downloaded desired files.

Is replace supported for builders in Page Examiner (Resolvers in AntiConatiner's terminology) rules?
Example of custom Page Examiner rule that didn't work:
Pattern: src="(.*_thumb\.jpg)"
Replacement: {replace:1,_thumb\.jpg,_original.jpg}

I would like to set sub-folders for downloads. Is that possible with myAntiContainer?

It would be convenient with a possibility to copy rules. That would speed up writing new rules. I noticed that "Add rule" kinda works like that. The "Add rule" function is clever, but it has a bug. When updating the new rule it also updates the original.
The rules list loses its selection/position when pressing Update Rule, that is a bit annoying.

A setting to deactivate selected rules would be convenient.

Do you have any plans for writing a help text? Or are you referring to AntiConatiner's wiki? AntiConatiner's old wiki is not that easy to read and leaves the reader with more questions than answers.

[blackadderkate]

Is myAntiContainer fully compatible with AntiContainer patterns (except sandbox)?
It should be. It uses standard Javascript Regular Expressions.

Can I add all my old patterns to your version (preferably in bulk by copying/moving them)?
Quantum does not allow you to import/export files from/to the Firefox folder, so the old method of creating JSON rules in the AntiContainer_plugins folder doesn't work. You will have to add them individually using the GUI.

"Load Rules" didn't do anything. And a bit confusing with both "Update Rule" and "Save These Rules", my interpretation is that update rule is for the active rule and save these is if you have loaded rules.

The rule buttons:

Update Rule - allows you to modify an existing rule. This rule is discarded when you close Firefox, unless you save it using "Save these rules". This is so that if your change doesn't work you can revert it back using "Load saved rules".

I had difficulties writing custom patterns and also using the existing ones didn't download desired data. I tried photobucket.com and gfycat.com, the pattern for those sites didn't download the desired images. Creating custom rules did not seem to work, neither simple Redirectors or Page Examiner rules downloaded desired files.

All the rules bundled with the extension are the original Anticontainer rules and likely out-of-date. The photobucket and gfycat rules probably need rewriting. I don't use those sites often, so they never got rewritten.

Is replace supported for builders in Page Examiner (Resolvers in AntiConatiner's terminology) rules? Example of custom Page Examiner rule that didn't work: Pattern: src="(.*_thumb\.jpg)" Replacement: {replace:1,_thumb\.jpg,_original.jpg}

Not sure without seeing the whole rule, but what you probably need is something like this:

Pattern: src="(.*)_thumb.jpg"
Replacement "{$1}_original.jpg"

I would like to set sub-folders for downloads. Is that possible with myAntiContainer?

Not at the moment. I was hoping I'd be able to "send" the modified URL to DownThemAll like the old extension did, but that isn't possible at the moment. I could probably add that functionality to the Helper App, but it would be complicated.

It would be convenient with a possibility to copy rules. That would speed up writing new rules. I noticed that "Add rule" kinda works like that. The "Add rule" function is clever, but it has a bug. When updating the new rule it also updates the original. The rules list loses its selection/position when pressing Update Rule, that is a bit annoying.

Add Rule is supposed to only update the new rule. I'll add this as a new issue.
I'll also add the Update Rule focus as a new issue.

A setting to deactivate selected rules would be convenient.

Easy to implement from a code perspective - it might a bit more difficult to display on the rules list...

Do you have any plans for writing a help text? Or are you referring to AntiConatiner's wiki? AntiConatiner's old wiki is not that easy to read and leaves the reader with more questions than answers.

Since it was originally only for my private use and such a "niche" extension, I didn't really feel the need to write any documentation. My other app (a Weather Widget for KDE Plasma) currently takes up most of my free time, but if I get sufficient demand I will...

[blackadderkate]

Incidentally, a good way to test your Page Examiners is using the Regex101 website.

For example, this is what your page examiner that didn't work should look like:

Your Finder is the Regular Expression - this is the string you are searching for in the webpage. This is highlighted in Blue. Note that we are not keeping the bit that reads "_thumb.jpg"
Your Builder is the unique "path" to the image (the bit in green) but we are appending "_original.jpg".

Incidentally, you should probably use (.+?) instead of (.*) as (.*) is "greedy" and might grab a bigger string than you expect.