Skip to content

Commit 8e32bf0

Browse files
committed
Remove Revise and simplify hcat
* Remove Revise from toml as mentionned in review * Remove hcat case 'more than 2 dims', as we do not pretend to handle it right now
1 parent b4770da commit 8e32bf0

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

src/sizes.jl

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -195,15 +195,14 @@ function _infer_sizes(
195195
end
196196
if sizes.ndims[children_arr[first(children_indices)]] == 0
197197
shape = (1, total_cols)
198-
elseif sizes.ndims[children_arr[first(children_indices)]] <= 2
198+
else
199+
@assert sizes.ndims[children_arr[first(
200+
children_indices,
201+
)]] <= 2 "Hcat with ndims > 2 is not supported yet"
199202
shape = (
200203
_size(sizes, children_arr[first(children_indices)], 1),
201204
total_cols,
202205
)
203-
else
204-
child_shape =
205-
_size(sizes, children_arr[first(children_indices)])
206-
shape = (child_shape[1], total_cols, child_shape[3:end]...)
207206
end
208207
_add_size!(sizes, k, tuple(shape...))
209208
elseif op == :*

test/Project.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@
22
ArrayDiff = "c45fa1ca-6901-44ac-ae5b-5513a4852d50"
33
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
44
MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
5-
Revise = "295af30f-e4ad-537b-8983-00126c2a3abe"
65
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
76
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

0 commit comments

Comments
 (0)