Merge pull request #655 from bleskodev/bd/settings-cleanup-tests-improvement

Add test to confirm fix for issue #674

Author: bleskodev

.rubocop.yml

@@ -0,0 +1,2 @@
+Style/GlobalVars:
+  AllowedVariables: [$rr_version, $rr_url]

.solargraph.yml

@@ -0,0 +1,22 @@
+---
+include:
+- "**/*.rb"
+exclude:
+- spec/**/*
+- test/**/*
+- vendor/**/*
+- ".bundle/**/*"
+require: []
+domains: []
+reporters:
+- rubocop
+- require_not_found
+formatter:
+  rubocop:
+    cops: safe
+    except: []
+    only: []
+    extra_args: []
+require_paths: []
+plugins: []
+max_files: 5000

spec/preferences/cleanup_specs.rb spec/preferences/cleanup_spec.rbspec/preferences/cleanup_specs.rb renamed to spec/preferences/cleanup_spec.rb

@@ -15,47 +15,54 @@
 #    You should have received a copy of the GNU General Public License
 #    along with this program.  If not, see <http://www.gnu.org/licenses/>
 #
+
+require 'rspec'
 require 'rubyripper/preferences/cleanup'
 require 'rubyripper/preferences/data'
 
 describe Preferences::Cleanup do
 
-  let (:prefs) { double('Preferences::Main').as_null_object }
-  let (:pref_data) { Preferences::Data.new }
-  let (:fileAndDir) { double('FileAndDir').as_null_object }
-  let (:cleanup) { Preferences::Cleanup.new(fileAndDir, prefs) }
+  let(:prefs) { double('Preferences::Main').as_null_object }
+  let(:pref_data) { Preferences::Data.new }
+  let(:fileAndDir) { double('FileAndDir').as_null_object }
+  let(:cleanup) { Preferences::Cleanup.new(fileAndDir, prefs) }
 
-  context "When settings contain references to freedb as selected metadata provider" do
+  context 'When settings contain references to freedb as selected metadata provider' do
     before(:each) do
-      pref_data.site = ""
-      pref_data.metadataProvider = ""
+      pref_data.site = ''
+      pref_data.metadataProvider = ''
       expect(prefs).to receive(:data).and_return pref_data
     end
 
-    it "should replace freedb with gnudb as selected metadata provider" do
+    it 'should replace freedb with gnudb as selected metadata provider' do
       pref_data.metadataProvider = 'freedb'
-      cleanup.migrateFreedbToGnudb()
+      cleanup.migrateFreedbToGnudb
       expect(pref_data.metadataProvider).to eq('gnudb')
     end
 
-    it "should not replace musicbrainz as selected metadata provider with gnudb" do
+    it 'should not replace musicbrainz as selected metadata provider with gnudb' do
       pref_data.metadataProvider = 'musicbrainz'
-      cleanup.migrateFreedbToGnudb()
+      cleanup.migrateFreedbToGnudb
       expect(pref_data.metadataProvider).to eq('musicbrainz')
     end
 
-    it "should not replace none as selected metadata provider with gnudb" do
+    it 'should not replace none as selected metadata provider with gnudb' do
       pref_data.metadataProvider = 'none'
-      cleanup.migrateFreedbToGnudb()
+      cleanup.migrateFreedbToGnudb
       expect(pref_data.metadataProvider).to eq('none')
     end
 
-    it "should replace freedb site with gnudb site" do
+    it 'should replace freedb site with gnudb site' do
       pref_data.site = 'http://freedb.freedb.org/~ccdb/ccdb.cgi'
-      cleanup.migrateFreedbToGnudb()
+      cleanup.migrateFreedbToGnudb
       expect(pref_data.site).to eq('http://gnudb.gnudb.org/~ccdb/ccdb.cgi')
     end
 
-  end
+    it 'should NOT replace freedb site with gnudb site when it is not a real/full match' do
+      pref_data.site = 'http://freedbtest.dyndns.org/~ccdb/ccdb.cgi'
+      cleanup.migrateFreedbToGnudb
+      expect(pref_data.site).to eq('http://freedbtest.dyndns.org/~ccdb/ccdb.cgi')
+    end
 
+  end
 end