Replies: 1 comment
-
|
Very nice, thank you! I think I'd vote for solution 2, especially since Second preference would be solution 3 but with the new package named |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
When I attempted to work on one of the codemod issues (#3601), I started looking into dependencies between packages. Especially between cli-related packages. In my case, I needed some utilities like fetch-latest-version, npm-fetch, etc., and they are currently in the
@blitzjs/generatorpackage. Though, in my opinion, they are quite general-purpose and not particularly related to the generator package. Ideally, in my opinion, I would see them as utilities in theblitzpackage for a few reasons:blitz.@blitzjs/generatorare strictly related to the generator.However, if we did that, there would be a circular dependency because
blitzhas@blitzjs/generatoras a dependency. I get why it’s done this way, but I’d still like to see the utilities elsewhere. Especially since I wanted to use one of them in the@blitzjs/codemod, and I don’t like the idea of this kind of dependency between@blitzjs/codemodand@blitzjs/generator(as, in my opinion, they are separate packages that could (should?) exist separately. I can also imagine that there can be other utilities that we’ll want to keep in the core (blitz) package AND re-use in other packages like@blitzjs/generator(which currently is not possible).See attached pictures for possible solutions.
Beta Was this translation helpful? Give feedback.
All reactions