Skip to content

Room For Improvement #1

Description

@LocalAlloc

The 'IsValidStopCode' function only performs a basic check to see if the stop code starts with "C". A more robust validation is needed to ensure only valid stop codes are used.
Perhaps you could consider using this modified function?
Thanks!
static bool IsValidStopCode(uint stopCode)
{
// Check if the stop code starts with "0x" (case-insensitive)
if (!stopCode.ToString("X").StartsWith("0x", StringComparison.OrdinalIgnoreCase))
{
return false;
}

// Extract the remaining hexadecimal digits (without "0x")
string codeString = stopCode.ToString("X").Substring(2);

// Check if the remaining string consists only of hexadecimal digits (0-9, A-F)
if (!System.Text.RegularExpressions.Regex.IsMatch(codeString, "^[0-9A-F]+$"))
{
return false;
}

// You can optionally add additional checks here,
// for example, define a list of known valid stop codes and check against it.

return true;
}

Metadata

Metadata

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions