RSS Wrapped in HTML

[ethan-eb]

Hi, after adding your plugin I realized my RSS feed was broken. I narrowed it down to rewrite_content where the DOMDocument is treated at HTML. My non-php-non-wordpress-programmer hack was to search for '<?xml' in the $content, then use that to decide between loadHTML/loadXML and saveHTML/saveXML.

Seems like a poor workaround, I'm sure you can solve it more elegantly.

Thanks

[chrismcmacken]

Thanks for taking the time to open an issue and let us know about it. I
won't have time to look into this until this weekend but I will try to have
a better answer for you by Sunday.

On Monday, December 31, 2012, ethan-eb wrote:

Hi, after adding your plugin I realized my RSS feed was broken. I narrowed
it down to rewrite_content where the DOMDocument is treated at HTML. My
non-php-non-wordpress-programmer hack was to search for '<?xml' in the
$content, then use that to decide between loadHTML/loadXML and
saveHTML/saveXML.

Seems like a poor workaround, I'm sure you can solve it more elegantly.

Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1.

[chrismcmacken]

Also, can you give me an example of the data that you don't want it to rewrite?

[ethan-eb]

So I actually do want the re-writing. The problem is that the content is all XML:

<rss xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:wfw="http://wellformedweb.org/CommentAPI/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:atom="http://www.w3.org/2005/Atom" xmlns:sy="http://purl.org/rss/1.0/modules/syndication/" xmlns:slash="http://purl.org/rss/1.0/modules/slash/" version="2.0">
    <channel><item>etc...</item></channel>
</rss>

When that is rendered with saveHTML, it gets wrapped up like an HTML page (don't remember if it just had the doctype for HTML or it was also wrapped in html tags). It was also returned with the wrong mimetype (eg. text/html vs. application/rss)

Sorry don't remember more specifics and I've got it fixed on my systems now. Thanks for looking into it.

[chrismcmacken]

If you look at commit 13015c1 I've fixed the bug where it breaks XML content but it still doesn't rewrite it properly. That will take a bit more work since the way it's being rewritten right now won't work for that. I haven't bumped the version yet or pushed a change to the WordPress plugin repo, I will do that once I get the rewriting fixed.

[ethan-eb]

Nice! thanks!

[chrismcmacken]

I have not forgotten about this issue but other projects have been taking priority lately, although I have a solution in mind. I hope to get to this before too long.