CYD-3248W535C fix and port

#108

Author: bmorcelli

boards/CYD-2432S028/custom_flags.py

@@ -24,7 +24,6 @@ def generate_build_flags(board_config):
     flags = []
 
     # Configurações de hardware
-    flags.append("-DROTATION=3")
     flags.append("-DHAS_BTN=0")
     flags.append("-DSEL_BTN=-1")
     flags.append("-DUP_BTN=-1")
@@ -60,6 +59,7 @@ def generate_build_flags(board_config):
         flags.append("-DTFT_ROW_OFS1=0")
         flags.append("-DTFT_COL_OFS2=0")
         flags.append("-DTFT_ROW_OFS2=0")
+        flags.append("-DROTATION=3")
 
     elif any("DISPLAY_ST7796_SPI" in flag for flag in extra_flags):
         flags.append("-DST7796_DRIVER=1")
@@ -77,6 +77,7 @@ def generate_build_flags(board_config):
         flags.append("-DTFT_ROW_OFS1=0")
         flags.append("-DTFT_COL_OFS2=0")
         flags.append("-DTFT_ROW_OFS2=0")
+        flags.append("-DROTATION=3")
 
     elif any("DISPLAY_ST7789_SPI" in flag for flag in extra_flags):
         flags.append("-DST7789_DRIVER=1")
@@ -94,6 +95,7 @@ def generate_build_flags(board_config):
         flags.append("-DTFT_ROW_OFS1=0")
         flags.append("-DTFT_COL_OFS2=0")
         flags.append("-DTFT_ROW_OFS2=0")
+        flags.append("-DROTATION=3")
 
     elif any("DISPLAY_AXS15231B_QSPI" in flag for flag in extra_flags):
         flags.append("-DAXS15231B_QSPI=1")
@@ -115,6 +117,7 @@ def generate_build_flags(board_config):
         flags.append("-DTFT_ROW_OFS1=0")
         flags.append("-DTFT_COL_OFS2=0")
         flags.append("-DTFT_ROW_OFS2=0")
+        flags.append("-DROTATION=0")
 
 
     elif any("DISPLAY_ST7789_I80" in flag for flag in extra_flags):
@@ -147,18 +150,21 @@ def generate_build_flags(board_config):
         flags.append("-DTFT_IPS=0")
         flags.append("-DTFT_COL_OFS1=0")
         flags.append("-DTFT_ROW_OFS1=0")
+        flags.append("-DROTATION=3")
 
     elif any("DISPLAY_ST7262_PAR" in flag for flag in extra_flags):
         flags.append("-DRGB_PANEL=1")
         flags.append("-DTFT_BL=GPIO_BCKL")
         flags.append("-DTFT_WIDTH=DISPLAY_WIDTH")
         flags.append("-DTFT_HEIGHT=DISPLAY_HEIGHT")
+        flags.append("-DROTATION=3")
 
     elif any("DISPLAY_ST7701_PAR" in flag for flag in extra_flags):
         flags.append("-DRGB_PANEL=1")
         flags.append("-DTFT_BL=GPIO_BCKL")
         flags.append("-DTFT_WIDTH=DISPLAY_WIDTH")
         flags.append("-DTFT_HEIGHT=DISPLAY_HEIGHT")
+        flags.append("-DROTATION=3")
 
 
     else:
@@ -177,6 +183,7 @@ def generate_build_flags(board_config):
         flags.append("-DTFT_ROW_OFS1=0")
         flags.append("-DTFT_COL_OFS2=0")
         flags.append("-DTFT_ROW_OFS2=0")
+        flags.append("-DROTATION=3")
 
     # Verifica suporte ao touch
     if any("TOUCH_XPT2046_SPI" in flag for flag in extra_flags):

boards/CYD-2432S028/interface.cpp

@@ -187,13 +187,14 @@ void _setBrightness(uint8_t brightval) {
 **********************************************************************/
 void InputHandler(void) {
     static long d_tmp = millis();
+    bool touched = touch.touched(); // read every cycle to skip bad readings
     if (millis() - d_tmp > 250 || LongPress) { // I know R3CK.. I Should NOT nest if statements..
         // but it is needed to not keep SPI bus used without need, it save resources
         TouchPoint t;
 #ifdef DONT_USE_INPUT_TASK
         checkPowerSaveTime();
 #endif
-        if (touch.touched()) {
+        if (touched) {
             auto t = touch.getPointScaled();
             d_tmp = millis();
 #ifdef DONT_USE_INPUT_TASK // need to reset the variables to avoid ghost click

boards/CYD-2432S028/platformio.ini

@@ -245,6 +245,7 @@ build_flags =
 	-DTFT_WIDTH=DISPLAY_WIDTH
 	-DTFT_HEIGHT=DISPLAY_HEIGHT
 	-DTFT_BL=GPIO_BCKL
+	-DUSE_CANVAS=1
 
 
 [env:CYD-4827S043R]

boards/_jsonfiles/esp32s3-3248W535N.json

@@ -54,7 +54,12 @@
       "'-D AXS15231B_TOUCH_I2C_IRQ=3'",
       "'-D DISPLAY_SWAP_XY=false'",
       "'-D DISPLAY_MIRROR_X=false'",
-      "'-D DISPLAY_MIRROR_Y=false'"
+      "'-D DISPLAY_MIRROR_Y=false'",
+      "'-D BOARD_HAS_TF'",
+      "'-D TF_CS=10'",
+      "'-D TF_SPI_MOSI=11'",
+      "'-D TF_SPI_SCLK=12'",
+      "'-D TF_SPI_MISO=13'"
     ],
     "f_cpu": "240000000L",
     "f_flash": "80000000L",
@@ -85,4 +90,4 @@
   },
   "url": "https://nl.aliexpress.com/item/1005007593889279.html",
   "vendor": "Guition"
-}
+}

src/tft.h

@@ -600,10 +600,20 @@ class Ard_eSPI : public ARD_TFT_BASE {
         uint16_t ro1, uint16_t co2, uint16_t ro2
     )
 #ifdef USE_CANVAS
+#ifdef ARDUINO_T_WATCH_S3_ULTRA
         : ARD_TFT_BASE(rotation & 0x1 ? h : w, rotation & 0x1 ? w : h, nullptr, 0, 0, 0),
           _outputDriver(_TFT_DRVF(bus, rst, rotation, ips, w, h, co1, ro1, co2, ro2)) {
         this->_output = &_outputDriver;
     }
+#else
+        // Canvas must be created with the physical (unrotated) dimensions and the
+        // desired rotation so that its internal framebuffer layout matches what
+        // the output driver expects when flush() calls draw16bitRGBBitmap(WIDTH, HEIGHT).
+        : ARD_TFT_BASE(w, h, nullptr, 0, 0, rotation),
+          _outputDriver(_TFT_DRVF(bus, rst, 0, 1, w, h, co1, ro1, co2, ro2)) {
+        this->_output = &_outputDriver;
+    }
+#endif
 #else
         : _TFT_DRVF(bus, rst, rotation, ips, w, h, co1, ro1, co2, ro2) {
     }
@@ -619,8 +629,14 @@ class Ard_eSPI : public ARD_TFT_BASE {
 #ifdef USE_CANVAS
     inline bool begin(int32_t speed = GFX_NOT_DEFINED) { return ARD_TFT_BASE::begin(speed); }
     inline void setRotation(uint8_t rot) {
+#ifdef ARDUINO_T_WATCH_S3_ULTRA
         // ARD_TFT_BASE::setRotation(rot);
         _outputDriver.setRotation(rot);
+#else
+
+        // Canvas handles rotation in the framebuffer; do not rotate the output driver.
+        ARD_TFT_BASE::setRotation(rot);
+#endif
     }
     inline void invertDisplay(bool i) { _outputDriver.invertDisplay(i); }
 #endif