Skip to content

approve pull + logout == failure #43

@braddr

Description

@braddr

Logging out tosses away the github access token. In the future, when conditions are met and an attempt to perform the merge happens, the check to make sure the user is still authorized to merge fails. If that step was omitted the merge itself would also fail.

Another failure mode that can occur is if the user is still logged in to the a-t, thus we still have an access token, but it's been revoked on github.

None of these errors are surfaced to the ui in any way.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions