fixed comments

Author: tylerfong

v1/providers/sfcompute/instance.go

@@ -476,6 +476,7 @@ func sfcNameToBrevData(name string) (cloudCredRefID string, brevStage string, re
 		return parts[0], parts[1], parts[2], parts[3], nil
 	case 2:
 		// Old format: refID_name (backward compat — cloudCredRefID and stage unknown)
+		// TODO: remove this case once all old-format nodes have been cleaned up
 		return "", "", parts[0], parts[1], nil
 	default:
 		return "", "", "", "", errors.WrapAndTrace(fmt.Errorf("invalid node name %s: expected 2 or 4 underscore-separated parts", name))

v1/providers/sfcompute/instancetype.go

@@ -21,6 +21,11 @@ const (
 	interconnectInfiniband = "infiniband"
 	formFactorSXM5         = "sxm5"
 	diskTypeSSD            = "ssd"
+
+	// Currently only 8xH100/H200 instance types are available
+	// so it's safe to hardcode vCPU and GPU count.
+	sfcVCPU     = 112
+	sfcGPUCount = 8
 )
 
 func makeDefaultInstanceTypePrice(amount string, currencyCode string) currency.Amount {
@@ -236,18 +241,14 @@ func getInstanceTypeMetadata(gpuType string) (*sfcInstanceTypeMetadata, error) {
 	}
 }
 
-// vCPU count provided by SF Compute. Currently only 8xH100/H200 instance types are
-// available so it's safe to hardcode.
-const sfcVCPU = 112
-
 var h100InstanceTypeMetadata = sfcInstanceTypeMetadata{
 	gpuType:             gpuTypeH100,
 	formFactor:          formFactorSXM5,
 	architecture:        v1.ArchitectureX86_64,
 	memoryBytes:         v1.NewBytes(960, v1.Gigabyte),
 	diskBytes:           v1.NewBytes(1500, v1.Gigabyte),
 	vcpu:                sfcVCPU,
-	gpuCount:            8,
+	gpuCount:            sfcGPUCount,
 	gpuManufacturer:     v1.ManufacturerNVIDIA,
 	gpuVRAM:             v1.NewBytes(80, v1.Gigabyte),
 	estimatedDeployTime: 14 * time.Minute,
@@ -261,7 +262,7 @@ var h200InstanceTypeMetadata = sfcInstanceTypeMetadata{
 	memoryBytes:         v1.NewBytes(960, v1.Gigabyte),
 	diskBytes:           v1.NewBytes(1500, v1.Gigabyte),
 	vcpu:                sfcVCPU,
-	gpuCount:            8,
+	gpuCount:            sfcGPUCount,
 	gpuManufacturer:     v1.ManufacturerNVIDIA,
 	gpuVRAM:             v1.NewBytes(141, v1.Gigabyte),
 	estimatedDeployTime: 14 * time.Minute,