Skip to content

Commit dac7259

Browse files
committed
Add duplicated fields to timeline parser.
- victimTeamfightDamageDealt and victimTeamfightDamageReceived fields were added to the timeline response. As far as I can tell, they are duplicates of the already existing victimDamageDealt and victimDamageReceived fields, so I'm not sure why they exist. - RiotGames/developer-relations#926 (comment)
1 parent 6abdfbc commit dac7259

2 files changed

Lines changed: 27 additions & 3 deletions

File tree

match/parsers/timeline.py

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,22 @@ class VictimDamageReceivedModel(VictimDamageDealtModel):
110110
...
111111

112112

113+
class VictimTeamfightDamageDealtModel(BaseModelWithLogger):
114+
basic: bool
115+
magicDamage: int
116+
name: str
117+
participantId: int
118+
physicalDamage: int
119+
spellName: str
120+
spellSlot: int
121+
trueDamage: int
122+
type: str
123+
124+
125+
class VictimTeamfightDamageReceivedModel(VictimTeamfightDamageDealtModel):
126+
...
127+
128+
113129
class ChampionKillEventModel(BaseModelWithLogger):
114130
type: Literal["CHAMPION_KILL"]
115131
assistingParticipantIds: list[int] | None = None
@@ -122,8 +138,16 @@ class ChampionKillEventModel(BaseModelWithLogger):
122138
victimDamageDealt: list[VictimDamageDealtModel] | None = None
123139
victimDamageReceived: list[VictimDamageReceivedModel] | None = None
124140
victimId: int
125-
126-
@field_validator("victimDamageDealt", "victimDamageReceived", mode='before')
141+
victimTeamfightDamageDealt: list[VictimTeamfightDamageDealtModel] | None = None
142+
victimTeamfightDamageReceived: list[VictimTeamfightDamageReceivedModel] | None = None
143+
144+
@field_validator(
145+
"victimDamageDealt",
146+
"victimDamageReceived",
147+
"victimTeamfightDamageDealt",
148+
"victimTeamfightDamageReceived",
149+
mode='before',
150+
)
127151
@classmethod
128152
def victim_damage_defaults(cls, v):
129153
if not v:

match/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ def import_advanced_timeline(match_id: str | int, overwrite=False):
510510

511511
pframes = []
512512
cke_to_save = []
513-
cke_events = []
513+
cke_events: list[tmparsers.ChampionKillEventModel] = []
514514
for frame, fm in zip(frames_to_save, data.frames):
515515
for pfm in fm.participantFrames.values():
516516
stats = pfm.championStats

0 commit comments

Comments
 (0)