From 301edbc44cbc920a5a673617f703669183e25985 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Sun, 22 Feb 2026 11:06:45 +0900 Subject: [PATCH 1/5] add contributing and release sections to README --- README.md | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/README.md b/README.md index f0e3a13..50629bc 100644 --- a/README.md +++ b/README.md @@ -42,6 +42,32 @@ steps: - `edge-version`: The installed Edge version. Useful when given a latest version. - `edge-path`: The installed Edge path. +## Contributing + +```bash +# Instal dependencies +pnpm install + +# Run tests +pnpm lint +pnpm test + +# Build and create package in dist/ +pnpm build +pnpm package +``` + +## Release + +Releases are automated with Release Please. All changes must follow [Conventional Commits][], since Release Please derives versions and changelog entries from commit messages. + +1. Merge some changes to the main branch. +2. Release Please opens or updates a release PR with version bumps and changelog updates. +3. Squash and merge the release PR to the main branch with a commit message that follows [Conventional Commits][]. +4. Create a GitHub release and publish the action to the marketplace. + +[Conventional Commits]: https://www.conventionalcommits.org/en/v1.0.0/ + ## License [MIT](LICENSE) From dd3bce83c9067a82c774d7ea59b41c64cda2f6ff Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Sun, 22 Feb 2026 11:07:41 +0900 Subject: [PATCH 2/5] bump Node.js version to 24.0.0 --- action.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/action.yml b/action.yml index 52cae03..c1b7e46 100644 --- a/action.yml +++ b/action.yml @@ -13,5 +13,5 @@ outputs: edge-path: description: 'The installed Edge path.' runs: - using: 'node20' + using: 'node24' main: 'index.js' diff --git a/package.json b/package.json index 8be9b5f..53f2157 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "main": "dist/index.js", "packageManager": "pnpm@8.7.5", "engines": { - "node": "20.6.1" + "node": ">=24.0.0" }, "dependencies": { "@actions/core": "^1.10.1", From 6c785238acdfc49400afe582120034dd9bc0f75f Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Sun, 22 Feb 2026 20:57:20 +0900 Subject: [PATCH 3/5] improve error message when edge is already installed --- src/index.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/index.ts b/src/index.ts index 6054c04..9260082 100644 --- a/src/index.ts +++ b/src/index.ts @@ -31,7 +31,8 @@ async function run(): Promise { const result = await (async () => { const installed = await installer.checkInstalled(version); if (installed) { - core.info(`Edge ${version} is already installed @ ${installed.root}`); + const bin = path.join(installed.root, installed.bin); + core.info(`Edge ${version} is already installed @ ${bin}`); return installed; } From 02d48b7701e6cf6acde9ac948243ef9599377c79 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Sun, 22 Feb 2026 21:13:34 +0900 Subject: [PATCH 4/5] ignore dist directory from biome --- biome.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/biome.json b/biome.json index 96e61d4..5720642 100644 --- a/biome.json +++ b/biome.json @@ -1,6 +1,6 @@ { "files": { - "ignore": ["package.json", "__test__/*.json"] + "ignore": ["package.json", "__test__/*.json", "dist"] }, "linter": { "enabled": true, From 62ad9b3373f85eb989583b750f8a1511a3b2886e Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Sun, 22 Feb 2026 21:38:44 +0900 Subject: [PATCH 5/5] Call Get-Item instead of wmic to get the version --- src/installer_windows.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/installer_windows.ts b/src/installer_windows.ts index d28499a..52585c8 100644 --- a/src/installer_windows.ts +++ b/src/installer_windows.ts @@ -101,12 +101,11 @@ export class WindowsInstaller implements Installer { async test(_version: versions.Version): Promise { const msedgeBin = await io.which("msedge", true); - await exec.exec("wmic", [ - "datafile", - "where", - `name="${msedgeBin.replace(/\\/g, "\\\\")}"`, - "get", - "version", + await exec.exec("powershell", [ + "-NoProfile", + "-NonInteractive", + "-Command", + `(Get-Item (Get-Command '${msedgeBin}').Source).VersionInfo.ProductVersion`, ]); } }